[jira] Updated: (MRELEASE-83) Wrong username during release:prepare tagging

["Raphael Ackermann (JIRA)" <ji...@codehaus.org>]

     [ http://jira.codehaus.org/browse/MRELEASE-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raphael Ackermann updated MRELEASE-83:
--------------------------------------

    Attachment: AbstractCvsCheckInCommand.java.patch

The attached patch fixes this issue for me when using CVS (the all java cvs client)

I get the same result that the first Login and also the update cvs commands work, but the checkin and tag commands won't work. As others have commented before, it uses the username defined in the CVS/Root file. Debugging the code I found out that it always checks the CVS/Root file, but if there is a -d option that takes precedence. 

-d cvs_root_directory
         Use cvs_root_directory as the root directory pathname of the  reposi-
         tory.   Overrides  the  setting of the $CVSROOT environment variable.
         See `Repository' in the CVS manual.

A change in revision 518698 changed the behaviour to not include the -d option when generating the tag, checkin, update and branch cvs commands. The comment for that revision indicates that this was a problem for the update command. I think that maybe it should have only be changed for the update command while leaving the tag and checkin behaviour to include the -d option. 

See the comment for rev 518698 below:

Revision: 518698
Author: evenisse
Date: 3/15/07 6:17 PM
Comment:
Remove cvsroot from the command when it isn't needed. It fix some pb with update when files are updated only on the root directory and not detected.

> Wrong username during release:prepare tagging
> ---------------------------------------------
>
>                 Key: MRELEASE-83
>                 URL: http://jira.codehaus.org/browse/MRELEASE-83
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: scm
>            Reporter: Niclas Hedhman
>         Attachments: AbstractCvsCheckInCommand.java.patch
>
>
> If I my Svn repository requires a different username than the login name, and I issue 
>    mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
>   maven.username=niclas@hedhman.org
> and everything will work.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira