You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/08/01 23:19:35 UTC
[GitHub] [iceberg] rdblue opened a new pull request #2906: Core: Fix partition field IDs in table replacement
rdblue opened a new pull request #2906:
URL: https://github.com/apache/iceberg/pull/2906
This fixes partition field ID assignment for `REPLACE TABLE` operations. Table replacement calls `TableMetadata.buildReplacement` that is responsible for merging the existing table's metadata with table metadata passed to the `CREATE OR REPLACE TABLE` DDL. When the schema and partition spec are created in this path, the field IDs from the table are not known, so the spec and schema's IDs are consistent but reuse IDs that are already assigned in the table. Schema field IDs are already reassigned, but partition field IDs were conflicting up until now.
This reassigns partition field IDs by first reusing existing IDs in the table and then by assigning new IDs.
Addresses this comment: https://github.com/apache/iceberg/pull/2089#discussion_r567154516
Closes #2284.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2906: Core: Fix partition field IDs in table replacement
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2906:
URL: https://github.com/apache/iceberg/pull/2906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2906: Core: Fix partition field IDs in table replacement
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2906:
URL: https://github.com/apache/iceberg/pull/2906#issuecomment-891396065
Thanks for reviewing, @jackye1995! I'm updating the tests as this catches more. It's just a few places that were changed by the behavior fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2906: Core: Fix partition field IDs in table replacement
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2906:
URL: https://github.com/apache/iceberg/pull/2906#issuecomment-892031173
Late +1 from me too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org