You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/02 09:52:41 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #3791: [WIP]
server: fix checking disk offering access for snapshot volume
shwstppr opened a new pull request #3791: [WIP] server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791
Fixes #3783
As reported in the issue, creating volumes from pure snapshot fails with NPE. This is due to order of calls where disk offering access is checked before checking disk offering value. This PR fixes the same.
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3791: server: fix checking
disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3791: server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791#issuecomment-580665018
Agree @DaanHoogland
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3791: server: fix checking
disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3791: server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791#issuecomment-579682296
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3791: server: fix
checking disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3791: server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791#issuecomment-579732514
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3791: [WIP] server:
fix checking disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3791: [WIP] server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791#issuecomment-572556519
Milestone for this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3791: server: fix
checking disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3791: server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791#issuecomment-579707912
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-686
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] shwstppr opened a new pull request #3791: server: fix
checking disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
shwstppr opened a new pull request #3791: server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791
Fixes #3783
As reported in the issue, creating volumes from pure snapshot fails with NPE. This is due to order of calls where disk offering access is checked before checking disk offering value. This PR fixes the same.
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3791: server: fix
checking disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3791: server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791#issuecomment-579088779
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd closed pull request #3791: server: fix checking
disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #3791: server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3791: [WIP] server:
fix checking disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3791: [WIP] server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791#issuecomment-570500365
you didn't need to open a new PR @shwstppr . you can force push to your own branch and then change the base branch on your PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3791: server: fix
checking disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3791: server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791#issuecomment-579104779
Packaging result: ✖centos6 ✖centos7 ✖debian. JID-668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3791: server: fix
checking disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3791: server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791#issuecomment-580148681
I don't see a relation of the errors with the change, @rhtyd @shwstppr ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3791: server: fix
checking disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3791: server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791#issuecomment-579969153
<b>Trillian test result (tid-840)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30714 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3791-t840-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_redundant_VPC_default_routes | `Failure` | 242.80 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 155.49 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 117.72 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 217.35 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 246.86 | test_vpc_redundant.py
test_01_vpc_site2site_vpn_multiple_options | `Error` | 295.98 | test_vpc_vpn.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3791: server: fix
checking disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3791: server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791#issuecomment-579732692
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3791: [WIP] server: fix
checking disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #3791: [WIP] server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791#issuecomment-571971519
@DaanHoogland didn't know that, will keep in mind for future. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3791: server: fix checking
disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #3791: server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3791: server: fix
checking disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3791: server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791#issuecomment-579682503
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3791: server: fix checking
disk offering access for snapshot volume
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3791: server: fix checking disk offering access for snapshot volume
URL: https://github.com/apache/cloudstack/pull/3791#issuecomment-579088584
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services