You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/04/06 08:46:59 UTC
[GitHub] [hive] marton-bod commented on a change in pull request #2111: HIVE-24928: In case of non-native tables use basic statistics from HiveStorageHandler
marton-bod commented on a change in pull request #2111:
URL: https://github.com/apache/hive/pull/2111#discussion_r607658821
##########
File path: iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -92,6 +99,11 @@
Types.TimestampType.withoutZone(), Types.StringType.get(), Types.BinaryType.get(),
Types.DecimalType.of(3, 1), Types.UUIDType.get(), Types.FixedType.ofLength(5),
Types.TimeType.get());
+ private static final Map<String, String> STATS_MAPPING = ImmutableMap.of(
+ StatsSetupConst.NUM_FILES, SnapshotSummary.TOTAL_DATA_FILES_PROP,
+ StatsSetupConst.ROW_COUNT, SnapshotSummary.TOTAL_RECORDS_PROP
+ // TODO: add ROW_COUNT -> TOTAL_SIZE mapping after iceberg 0.12 is released
Review comment:
small typo: TOTAL_SIZE -> TOTAL_FILE_SIZE_PROP mapping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org