You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/07/01 05:14:10 UTC

[GitHub] [phoenix-queryserver] stoty commented on pull request #39: PHOENIX-5901 Fix licensing in preparation for first python release

stoty commented on pull request #39:
URL: https://github.com/apache/phoenix-queryserver/pull/39#issuecomment-652195657


   +1 LGTM
   
   I think that I did see the output of the scripts previously, but honestly I was more concerned with letting the scripts finish, rather than hanging indefinitely with a full stdout/stderr buffer, than with the output :)
   
   Anyway, your solution is much cleaner than relying on the JVM exit cleanups.
   
   I've run built it with both default settings,  and the full python test suite, and everything looks great.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org