[GitHub] betodealmeida commented on a change in pull request #5621: Fix annotation_json endpoint

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #5621: Fix annotation_json endpoint
URL: https://github.com/apache/incubator-superset/pull/5621#discussion_r209814427
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -380,12 +380,6 @@ def get_df_payload(self, query_obj=None):
         if query_obj and not is_loaded:
             try:
                 df = self.get_df(query_obj)
-                if hasattr(self.datasource.database, 'db_engine_spec'):
-                    db_engine_spec = self.datasource.database.db_engine_spec
-                    df = db_engine_spec.adjust_df_column_names(df, self.form_data)
-                if self.status != utils.QueryStatus.FAILED:
-                    stats_logger.incr('loaded_from_source')
-                    is_loaded = True
 
 Review comment:
   Same here: why is this broken? I'm worried changing this will break existing code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org