You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Dinesh Chitlangia (JIRA)" <ji...@apache.org> on 2019/04/26 20:45:00 UTC

[jira] [Commented] (YARN-9171) Replace incorrect use of system property user.name

    [ https://issues.apache.org/jira/browse/YARN-9171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827312#comment-16827312 ] 

Dinesh Chitlangia commented on YARN-9171:
-----------------------------------------

[~jojochuang] All other reported occurrences have been fixed by other JIRAs.
The only class that still has this is CGroupsHandlerImpl and I believe it is fine to not modify this one.
{code:java}
/**
 * Creates an actionable error message for mtab parsing.
 * @param errorMessage message to use
 * @param subsystemName cgroup subsystem
 * @param yarnCgroupPath cgroup path that failed
 * @return a string builder that can be appended by the caller
 */
private String getErrorWithDetails(
    String errorMessage,
    String subsystemName,
    String yarnCgroupPath) {
  return String.format("%s Subsystem:%s Mount points:%s User:%s Path:%s ",
      errorMessage, subsystemName, mtabFile, System.getProperty("user.name"),
      yarnCgroupPath);
}
{code}
Let me know your thoughts.

 

> Replace incorrect use of system property user.name
> --------------------------------------------------
>
>                 Key: YARN-9171
>                 URL: https://issues.apache.org/jira/browse/YARN-9171
>             Project: Hadoop YARN
>          Issue Type: Improvement
>         Environment: Kerberized
>            Reporter: Dinesh Chitlangia
>            Assignee: Dinesh Chitlangia
>            Priority: Major
>
> This jira has been created to track the suggested changes for YARN as identified in HDFS-14176
> Following occurrences need to be corrected:
> YARN/ApiServiceClient L211
> YARN/CGroupsHandlerImpl L460
> YARN/YarnServiceJobSubmitter L216
> YARN/YarnClientImpl L1111 (here, it is using this pattern only if security is not enabled)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org