You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2014/08/04 15:29:26 UTC
svn commit: r1615552 - /logging/log4j/log4j2/trunk/log4j-perf/pom.xml
Author: ggregory
Date: Mon Aug 4 13:29:26 2014
New Revision: 1615552
URL: http://svn.apache.org/r1615552
Log:
Add missing Disruptor version.
Modified:
logging/log4j/log4j2/trunk/log4j-perf/pom.xml
Modified: logging/log4j/log4j2/trunk/log4j-perf/pom.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-perf/pom.xml?rev=1615552&r1=1615551&r2=1615552&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-perf/pom.xml (original)
+++ logging/log4j/log4j2/trunk/log4j-perf/pom.xml Mon Aug 4 13:29:26 2014
@@ -80,6 +80,7 @@
<dependency>
<groupId>com.lmax</groupId>
<artifactId>disruptor</artifactId>
+ <version>${disruptor.version}</version>
</dependency>
</dependencies>
Re: svn commit: r1615552 - /logging/log4j/log4j2/trunk/log4j-perf/pom.xml
Posted by Matt Sicker <bo...@gmail.com>.
This certainly should fix it. I removed the version previously and it was
using the same version as everything else, though. Either way works.
On 4 August 2014 10:19, Gary Gregory <ga...@gmail.com> wrote:
> The dependency report shows the perf and core modules using different
> versions of the Disruptor. I thought this would fix it.
>
> Gary
>
>
> On Mon, Aug 4, 2014 at 10:53 AM, Matt Sicker <bo...@gmail.com> wrote:
>
>> But this uses the parent pom version otherwise. I didn't think it was
>> necessary to have! But it's certainly a better idea to use the property
>> rather than hardcoded.
>>
>>
>> On 4 August 2014 08:35, Remko Popma <re...@gmail.com> wrote:
>>
>>> Thanks!
>>>
>>>
>>> On Mon, Aug 4, 2014 at 10:29 PM, <gg...@apache.org> wrote:
>>>
>>>> Author: ggregory
>>>> Date: Mon Aug 4 13:29:26 2014
>>>> New Revision: 1615552
>>>>
>>>> URL: http://svn.apache.org/r1615552
>>>> Log:
>>>> Add missing Disruptor version.
>>>>
>>>> Modified:
>>>> logging/log4j/log4j2/trunk/log4j-perf/pom.xml
>>>>
>>>> Modified: logging/log4j/log4j2/trunk/log4j-perf/pom.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-perf/pom.xml?rev=1615552&r1=1615551&r2=1615552&view=diff
>>>>
>>>> ==============================================================================
>>>> --- logging/log4j/log4j2/trunk/log4j-perf/pom.xml (original)
>>>> +++ logging/log4j/log4j2/trunk/log4j-perf/pom.xml Mon Aug 4 13:29:26
>>>> 2014
>>>> @@ -80,6 +80,7 @@
>>>> <dependency>
>>>> <groupId>com.lmax</groupId>
>>>> <artifactId>disruptor</artifactId>
>>>> + <version>${disruptor.version}</version>
>>>> </dependency>
>>>> </dependencies>
>>>>
>>>>
>>>>
>>>>
>>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
Matt Sicker <bo...@gmail.com>
Re: svn commit: r1615552 - /logging/log4j/log4j2/trunk/log4j-perf/pom.xml
Posted by Gary Gregory <ga...@gmail.com>.
The dependency report shows the perf and core modules using different
versions of the Disruptor. I thought this would fix it.
Gary
On Mon, Aug 4, 2014 at 10:53 AM, Matt Sicker <bo...@gmail.com> wrote:
> But this uses the parent pom version otherwise. I didn't think it was
> necessary to have! But it's certainly a better idea to use the property
> rather than hardcoded.
>
>
> On 4 August 2014 08:35, Remko Popma <re...@gmail.com> wrote:
>
>> Thanks!
>>
>>
>> On Mon, Aug 4, 2014 at 10:29 PM, <gg...@apache.org> wrote:
>>
>>> Author: ggregory
>>> Date: Mon Aug 4 13:29:26 2014
>>> New Revision: 1615552
>>>
>>> URL: http://svn.apache.org/r1615552
>>> Log:
>>> Add missing Disruptor version.
>>>
>>> Modified:
>>> logging/log4j/log4j2/trunk/log4j-perf/pom.xml
>>>
>>> Modified: logging/log4j/log4j2/trunk/log4j-perf/pom.xml
>>> URL:
>>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-perf/pom.xml?rev=1615552&r1=1615551&r2=1615552&view=diff
>>>
>>> ==============================================================================
>>> --- logging/log4j/log4j2/trunk/log4j-perf/pom.xml (original)
>>> +++ logging/log4j/log4j2/trunk/log4j-perf/pom.xml Mon Aug 4 13:29:26
>>> 2014
>>> @@ -80,6 +80,7 @@
>>> <dependency>
>>> <groupId>com.lmax</groupId>
>>> <artifactId>disruptor</artifactId>
>>> + <version>${disruptor.version}</version>
>>> </dependency>
>>> </dependencies>
>>>
>>>
>>>
>>>
>>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1615552 - /logging/log4j/log4j2/trunk/log4j-perf/pom.xml
Posted by Matt Sicker <bo...@gmail.com>.
But this uses the parent pom version otherwise. I didn't think it was
necessary to have! But it's certainly a better idea to use the property
rather than hardcoded.
On 4 August 2014 08:35, Remko Popma <re...@gmail.com> wrote:
> Thanks!
>
>
> On Mon, Aug 4, 2014 at 10:29 PM, <gg...@apache.org> wrote:
>
>> Author: ggregory
>> Date: Mon Aug 4 13:29:26 2014
>> New Revision: 1615552
>>
>> URL: http://svn.apache.org/r1615552
>> Log:
>> Add missing Disruptor version.
>>
>> Modified:
>> logging/log4j/log4j2/trunk/log4j-perf/pom.xml
>>
>> Modified: logging/log4j/log4j2/trunk/log4j-perf/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-perf/pom.xml?rev=1615552&r1=1615551&r2=1615552&view=diff
>>
>> ==============================================================================
>> --- logging/log4j/log4j2/trunk/log4j-perf/pom.xml (original)
>> +++ logging/log4j/log4j2/trunk/log4j-perf/pom.xml Mon Aug 4 13:29:26 2014
>> @@ -80,6 +80,7 @@
>> <dependency>
>> <groupId>com.lmax</groupId>
>> <artifactId>disruptor</artifactId>
>> + <version>${disruptor.version}</version>
>> </dependency>
>> </dependencies>
>>
>>
>>
>>
>
--
Matt Sicker <bo...@gmail.com>
Re: svn commit: r1615552 - /logging/log4j/log4j2/trunk/log4j-perf/pom.xml
Posted by Remko Popma <re...@gmail.com>.
Thanks!
On Mon, Aug 4, 2014 at 10:29 PM, <gg...@apache.org> wrote:
> Author: ggregory
> Date: Mon Aug 4 13:29:26 2014
> New Revision: 1615552
>
> URL: http://svn.apache.org/r1615552
> Log:
> Add missing Disruptor version.
>
> Modified:
> logging/log4j/log4j2/trunk/log4j-perf/pom.xml
>
> Modified: logging/log4j/log4j2/trunk/log4j-perf/pom.xml
> URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-perf/pom.xml?rev=1615552&r1=1615551&r2=1615552&view=diff
>
> ==============================================================================
> --- logging/log4j/log4j2/trunk/log4j-perf/pom.xml (original)
> +++ logging/log4j/log4j2/trunk/log4j-perf/pom.xml Mon Aug 4 13:29:26 2014
> @@ -80,6 +80,7 @@
> <dependency>
> <groupId>com.lmax</groupId>
> <artifactId>disruptor</artifactId>
> + <version>${disruptor.version}</version>
> </dependency>
> </dependencies>
>
>
>
>