You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "empiredan (via GitHub)" <gi...@apache.org> on 2025/04/11 03:40:39 UTC
[PR] Idempotent shell operate [incubator-pegasus]
empiredan opened a new pull request, #2221:
URL: https://github.com/apache/incubator-pegasus/pull/2221
https://github.com/apache/incubator-pegasus/issues/2197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] feat(make_idempotent): support `atomic_idempotent` for `create` and `ls` commands on shell [incubator-pegasus]
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #2221:
URL: https://github.com/apache/incubator-pegasus/pull/2221#discussion_r2042306829
##########
src/shell/command_utils.h:
##########
@@ -36,13 +37,14 @@ class host_port;
struct shell_context;
-// Check if there is not any other positional argument except the command, which means only
-// parameters and flags are needed.
-inline dsn::error_s no_pos_arg(const argh::parser &cmd)
+// Check if there is exact n positional arguments except the command, where n >= 0.
Review Comment:
```suggestion
// Check if there are exact n positional arguments except the command, where n >= 0.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] feat(make_idempotent): support `atomic_idempotent` for `create` and `ls` commands on shell [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan merged PR #2221:
URL: https://github.com/apache/incubator-pegasus/pull/2221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org