You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/30 10:18:22 UTC

[GitHub] [hudi] xicm commented on a diff in pull request #5286: [HUDI-3836] Improve the way of fetching metadata partitions from table

xicm commented on code in PR #5286:
URL: https://github.com/apache/hudi/pull/5286#discussion_r910856311


##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/minicluster/HdfsTestService.java:
##########
@@ -103,7 +103,9 @@ public MiniDFSCluster start(boolean format) throws IOException {
 
   public void stop() {
     LOG.info("HDFS Minicluster service being shut down.");
-    miniDfsCluster.shutdown();
+    if (miniDfsCluster != null) {
+      miniDfsCluster.shutdown();
+    }

Review Comment:
   fix NullPointerException
   ```
   java.lang.NullPointerException
   	at org.apache.hudi.common.testutils.minicluster.HdfsTestService.stop(HdfsTestService.java:106)
   	at org.apache.hudi.utilities.testutils.UtilitiesTestBase.cleanupClass(UtilitiesTestBase.java:136)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org