You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/08/09 00:03:42 UTC
[GitHub] [ozone] DaveTeng0 opened a new pull request, #3665: Add proper error message on console output when incorrect replication data-parity config is passed
DaveTeng0 opened a new pull request, #3665:
URL: https://github.com/apache/ozone/pull/3665
## What changes were proposed in this pull request?
Need proper error message on console output when incorrect replication data-parity config is passed
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7108
## How was this patch tested?
Manually test from developer machine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3665: HDDS-7108. Include supported EC data-parity combinations in error message
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3665:
URL: https://github.com/apache/ozone/pull/3665#discussion_r950675045
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/client/ReplicationConfigValidator.java:
##########
@@ -61,9 +61,11 @@ public ReplicationConfig validate(ReplicationConfig replicationConfig) {
replication = ecConfig.getCodec() + "-" + ecConfig.getData() +
"-" + ecConfig.getParity() + "-{CHUNK_SIZE}";
}
- throw new IllegalArgumentException("Invalid replication config " +
- "for type " + replicationConfig.getReplicationType() +
- " and replication " + replication);
+ throw new IllegalArgumentException(
+ "Invalid data-parity replication config " +
+ "for type " + replicationConfig.getReplicationType() +
+ " and replication " + replication + "." +
+ " Supported data-parity are 3-2,6-3,10-4");
Review Comment:
Sorry for the late review.
This exception may be thrown for non-EC replication config, too, in which case `data-parity` is not applicable. The message should be different based on replication type.
CLI commands validate RATIS replication factor before reaching this check, but Java code using `RpcClient#createKey` directly could encounter this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] DaveTeng0 commented on pull request #3665: Add proper error message on console output when incorrect replication data-parity config is passed
Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on PR #3665:
URL: https://github.com/apache/ozone/pull/3665#issuecomment-1210978383
> LGTM, please address failing CI tests
sure! looking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #3665: HDDS-7108. Include supported EC data-parity combinations in error message
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3665:
URL: https://github.com/apache/ozone/pull/3665#issuecomment-1221093221
Thank you, @DaveTeng0 for this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #3665: Add proper error message on console output when incorrect replication data-parity config is passed
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3665:
URL: https://github.com/apache/ozone/pull/3665#issuecomment-1210327795
LGTM, please address failing CI tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime merged pull request #3665: HDDS-7108. Include supported EC data-parity combinations in error message
Posted by GitBox <gi...@apache.org>.
kerneltime merged PR #3665:
URL: https://github.com/apache/ozone/pull/3665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] DaveTeng0 commented on pull request #3665: Add proper error message on console output when incorrect replication data-parity config is passed
Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on PR #3665:
URL: https://github.com/apache/ozone/pull/3665#issuecomment-1208747216
@umamaheswararao @kerneltime Feel free to take a look if the added message helps! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org