You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by moriarty <gi...@git.apache.org> on 2016/10/24 20:59:40 UTC

[GitHub] avro pull request #146: AVRO-1940: C++: scope enums into own namespaces

GitHub user moriarty opened a pull request:

    https://github.com/apache/avro/pull/146

    AVRO-1940: C++: scope enums into own namespaces

    Adds option to add namespace around all enums with the same name as the enum.
    https://issues.apache.org/jira/browse/AVRO-1940
    
    There are otherways to do this (c++11) but this way introduces less changes and doesn't break anything.
    
    Originally this was PR #145 but I have cherry-picked and cleaned up the commit on top of master instead of on top of PR #142 to make it easier to review. This code passes the original tests, but doesn't add any additional tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/moriarty/avro avro-1940/cpp-namespace-scoped-enums/dev

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/146.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #146
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---