You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by lianhuiwang <gi...@git.apache.org> on 2014/07/18 05:51:39 UTC

[GitHub] spark pull request: SPARK-2058: Overriding config from SPARK_HOME ...

Github user lianhuiwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/997#discussion_r15095873
  
    --- Diff: bin/compute-classpath.sh ---
    @@ -30,6 +30,11 @@ FWDIR="$(cd `dirname $0`/..; pwd)"
     # Build up classpath
     CLASSPATH="$SPARK_CLASSPATH:$SPARK_SUBMIT_CLASSPATH:$FWDIR/conf"
     
    +# If SPARK_CONF_DIR is defined give it preference over default conf in spark home
    +if [ -n "$SPARK_CONF_DIR" ]; then
    +  CLASSPATH="$SPARK_CONF_DIR:$CLASSPATH"
    --- End diff --
    
    also i think in standalone mode,worker need to use config. so the classpath is useful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---