You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@continuum.apache.org by Emmanuel Venisse <em...@venisse.net> on 2007/03/01 09:27:35 UTC
Re: svn commit: r512813 - /maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/
ok, I'll change them to input. I used doInput because it's the method name used in parent class.
Emmanuel
Brett Porter a écrit :
> Why is that the 'correct' method?
>
> In Struts 2.0, doInput has been removed in favour of input (rather, do*
> replaced by * in the general case).
>
> - Brett
>
> On 28/02/2007, at 11:41 PM, evenisse@apache.org wrote:
>
>> Author: evenisse
>> Date: Wed Feb 28 07:41:36 2007
>> New Revision: 512813
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=512813
>> Log:
>> o Replace all input() methods by the correct name(doInput())
>> o Don't allow execute/doDefault/doInput method so security checks will
>> be done correctly
>>
>> Modified:
>>
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectAction.java
>>
>>
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectGroupAction.java
>>
>>
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/BuildDefinitionAction.java
>>
>>
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ContinuumActionSupport.java
>>
>>
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleasePerformAction.java
>>
>>
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleasePrepareAction.java
>>
>>
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ScheduleAction.java
>>
>>
>> Modified:
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectAction.java
>>
>> URL:
>> http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectAction.java?view=diff&rev=512813&r1=512812&r2=512813
>>
>> ==============================================================================
>>
>> ---
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectAction.java
>> (original)
>> +++
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectAction.java
>> Wed Feb 28 07:41:36 2007
>> @@ -133,7 +133,7 @@
>> return SUCCESS;
>> }
>>
>> - public String input()
>> + public String doInput()
>> throws ContinuumException
>> {
>> try
>>
>> Modified:
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectGroupAction.java
>>
>> URL:
>> http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectGroupAction.java?view=diff&rev=512813&r1=512812&r2=512813
>>
>> ==============================================================================
>>
>> ---
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectGroupAction.java
>> (original)
>> +++
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/AddProjectGroupAction.java
>> Wed Feb 28 07:41:36 2007
>> @@ -100,7 +100,7 @@
>> return SUCCESS;
>> }
>>
>> - public String input()
>> + public String doInput()
>> {
>> try
>> {
>>
>> Modified:
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/BuildDefinitionAction.java
>>
>> URL:
>> http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/BuildDefinitionAction.java?view=diff&rev=512813&r1=512812&r2=512813
>>
>> ==============================================================================
>>
>> ---
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/BuildDefinitionAction.java
>> (original)
>> +++
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/BuildDefinitionAction.java
>> Wed Feb 28 07:41:36 2007
>> @@ -104,7 +104,7 @@
>> *
>> * @return action result
>> */
>> - public String input()
>> + public String doInput()
>> throws ContinuumException
>> {
>> try
>>
>> Modified:
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ContinuumActionSupport.java
>>
>> URL:
>> http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ContinuumActionSupport.java?view=diff&rev=512813&r1=512812&r2=512813
>>
>> ==============================================================================
>>
>> ---
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ContinuumActionSupport.java
>> (original)
>> +++
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ContinuumActionSupport.java
>> Wed Feb 28 07:41:36 2007
>> @@ -84,6 +84,24 @@
>> this.continuum = continuum;
>> }
>>
>> + public String doDefault()
>> + throws Exception
>> + {
>> + return REQUIRES_AUTHORIZATION;
>> + }
>> +
>> + public String doInput()
>> + throws Exception
>> + {
>> + return REQUIRES_AUTHORIZATION;
>> + }
>> +
>> + public String execute()
>> + throws Exception
>> + {
>> + return REQUIRES_AUTHORIZATION;
>> + }
>> +
>> /**
>> * Check if the current user is authorized to do the action
>> *
>>
>> Modified:
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleasePerformAction.java
>>
>> URL:
>> http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleasePerformAction.java?view=diff&rev=512813&r1=512812&r2=512813
>>
>> ==============================================================================
>>
>> ---
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleasePerformAction.java
>> (original)
>> +++
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleasePerformAction.java
>> Wed Feb 28 07:41:36 2007
>> @@ -81,7 +81,7 @@
>> return SUCCESS;
>> }
>>
>> - public String input()
>> + public String doInput()
>> throws Exception
>> {
>> try
>>
>> Modified:
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleasePrepareAction.java
>>
>> URL:
>> http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleasePrepareAction.java?view=diff&rev=512813&r1=512812&r2=512813
>>
>> ==============================================================================
>>
>> ---
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleasePrepareAction.java
>> (original)
>> +++
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleasePrepareAction.java
>> Wed Feb 28 07:41:36 2007
>> @@ -83,7 +83,7 @@
>>
>> private String projectGroupName = "";
>>
>> - public String input()
>> + public String doInput()
>> throws Exception
>> {
>> try
>>
>> Modified:
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ScheduleAction.java
>>
>> URL:
>> http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ScheduleAction.java?view=diff&rev=512813&r1=512812&r2=512813
>>
>> ==============================================================================
>>
>> ---
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ScheduleAction.java
>> (original)
>> +++
>> maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ScheduleAction.java
>> Wed Feb 28 07:41:36 2007
>> @@ -88,7 +88,7 @@
>> return SUCCESS;
>> }
>>
>> - public String input()
>> + public String doInput()
>> throws ContinuumException
>> {
>> try
>>
>
>
>
>