You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by JoseExposito <gi...@git.apache.org> on 2017/10/11 18:44:57 UTC
[GitHub] cordova-osx pull request #43: CB-13424: "cordova plugin add/remove" writes c...
GitHub user JoseExposito opened a pull request:
https://github.com/apache/cordova-osx/pull/43
CB-13424: "cordova plugin add/remove" writes changes in config.xml
See https://issues.apache.org/jira/browse/CB-13424 and https://github.com/apache/cordova-plugin-camera/pull/290 for a description of the issue.
This PR allows to add/remove plugins to the config.xml.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoseExposito/cordova-osx master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-osx/pull/43.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #43
----
commit c4b44ee1de415479a5d4a0da97988da18e786acd
Author: José Expósito <jo...@armourcomms.com>
Date: 2017-10-11T18:40:55Z
CB-13424: When running "cordova plugin add/remove" plugins are added and removed properly to the osx platform config.xml file
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx issue #43: CB-13424: "cordova plugin add/remove" writes changes ...
Posted by JoseExposito <gi...@git.apache.org>.
Github user JoseExposito commented on the issue:
https://github.com/apache/cordova-osx/pull/43
Thanks for reviewing @giuseppelt, changed
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx pull request #43: CB-13424: "cordova plugin add/remove" writes c...
Posted by giuseppelt <gi...@git.apache.org>.
Github user giuseppelt commented on a diff in the pull request:
https://github.com/apache/cordova-osx/pull/43#discussion_r145098266
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -199,8 +201,8 @@ Api.prototype.addPlugin = function (plugin, installOptions) {
* CordovaError instance.
*/
Api.prototype.removePlugin = function (plugin, uninstallOptions) {
- var Plugman = require('./lib/plugman/Plugman');
- return Plugman.get(this.locations, this.events).removePlugin(plugin, uninstallOptions);
+ var xcodeproj = projectFile.parse(this.locations);
+ return PluginManager.get(self.platform, self.locations, xcodeproj).removePlugin(plugin, uninstallOptions)
--- End diff --
`self` is undefined here
replace with `this`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx issue #43: CB-13424: "cordova plugin add/remove" writes changes ...
Posted by JoseExposito <gi...@git.apache.org>.
Github user JoseExposito commented on the issue:
https://github.com/apache/cordova-osx/pull/43
Indeed, the logic comes from iOS/Android.
Basically, I updated the cordova-common library to match the iOS version and used it in the plugin add/remove hooks like other platforms are doing.
In my opinion the macOS platform will need more updates to match the structure other platforms are using... But for the moment this fixes the issue. Once I see if the team is open to community PRs you can expect more changes :)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-osx issue #43: CB-13424: "cordova plugin add/remove" writes changes ...
Posted by janpio <gi...@git.apache.org>.
Github user janpio commented on the issue:
https://github.com/apache/cordova-osx/pull/43
Yay, that was quick. Can you talk me (and everybody reading) through the changes? Where does the logic come from? ios?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org