You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/14 10:02:09 UTC
[GitHub] [spark] MaxGekk commented on a diff in pull request #36550: [SPARK-39187][SQL] Remove `SparkIllegalStateException`
MaxGekk commented on code in PR #36550:
URL: https://github.com/apache/spark/pull/36550#discussion_r872960720
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##########
@@ -272,15 +271,6 @@ class QueryExecutionErrorsSuite
}
}
- test("INTERNAL_ERROR: timeZoneId not specified while converting TimestampType to Arrow") {
- checkErrorClass(
- exception = intercept[SparkIllegalStateException] {
- ArrowUtils.toArrowSchema(new StructType().add("value", TimestampType), null)
Review Comment:
The internal API is tested by `ArrowUtilsSuite` already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org