You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/29 16:53:00 UTC
[GitHub] [airflow] Ayushsunny opened a new pull request #18610: fixed default value of execution_timeout in base operator
Ayushsunny opened a new pull request #18610:
URL: https://github.com/apache/airflow/pull/18610
Fixed #18578
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexInhert commented on a change in pull request #18610: fixed default value of execution_timeout in base operator
Posted by GitBox <gi...@apache.org>.
alexInhert commented on a change in pull request #18610:
URL: https://github.com/apache/airflow/pull/18610#discussion_r721339788
##########
File path: airflow/models/baseoperator.py
##########
@@ -502,7 +502,7 @@ def __init__(
pool: Optional[str] = None,
pool_slots: int = 1,
sla: Optional[timedelta] = None,
- execution_timeout: Optional[timedelta] = None,
+ execution_timeout: Optional[timedelta] = conf.gettimedelta('core', 'default_ execution_timeout', fallback=None),
Review comment:
execution_timeout accept timedelta object. You are reading value from a configuration file you need to convert it into the object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zevaverbach commented on a change in pull request #18610: fixed default value of execution_timeout in base operator
Posted by GitBox <gi...@apache.org>.
zevaverbach commented on a change in pull request #18610:
URL: https://github.com/apache/airflow/pull/18610#discussion_r728310523
##########
File path: airflow/models/baseoperator.py
##########
@@ -502,7 +502,7 @@ def __init__(
pool: Optional[str] = None,
pool_slots: int = 1,
sla: Optional[timedelta] = None,
- execution_timeout: Optional[timedelta] = None,
+ execution_timeout: Optional[timedelta] = conf.gettimedelta('core', 'default_ execution_timeout', fallback=None),
Review comment:
I'd like to take this task over if @Ayushsunny is okay with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Ayushsunny commented on a change in pull request #18610: fixed default value of execution_timeout in base operator
Posted by GitBox <gi...@apache.org>.
Ayushsunny commented on a change in pull request #18610:
URL: https://github.com/apache/airflow/pull/18610#discussion_r719042085
##########
File path: airflow/models/baseoperator.py
##########
@@ -502,7 +502,7 @@ def __init__(
pool: Optional[str] = None,
pool_slots: int = 1,
sla: Optional[timedelta] = None,
- execution_timeout: Optional[timedelta] = None,
+ execution_timeout: Optional[timedelta] = conf.gettimedelta('core', 'default_ execution_timeout', fallback=None),
Review comment:
@alexInhert What's `gettimedelta` function supposed to do here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18610: fixed default value of execution_timeout in base operator
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18610:
URL: https://github.com/apache/airflow/pull/18610#issuecomment-930395219
In order to be able to get that in we need:
* some unit test cases covering this
* configuration description update https://github.com/apache/airflow/tree/main/airflow/config_templates
* docstrings updated to explain the behaviour
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexInhert commented on a change in pull request #18610: fixed default value of execution_timeout in base operator
Posted by GitBox <gi...@apache.org>.
alexInhert commented on a change in pull request #18610:
URL: https://github.com/apache/airflow/pull/18610#discussion_r718770145
##########
File path: airflow/models/baseoperator.py
##########
@@ -502,7 +502,7 @@ def __init__(
pool: Optional[str] = None,
pool_slots: int = 1,
sla: Optional[timedelta] = None,
- execution_timeout: Optional[timedelta] = None,
+ execution_timeout: Optional[timedelta] = conf.gettimedelta('core', 'default_ execution_timeout', fallback=None),
Review comment:
there is no `gettimedelta` function in https://github.com/apache/airflow/blob/main/airflow/configuration.py . You need to implement it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18610: fixed default value of execution_timeout in base operator
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18610:
URL: https://github.com/apache/airflow/pull/18610#issuecomment-930395219
In order to be able to get that in we need:
* some unit test cases covering this
* configuration description update https://github.com/apache/airflow/tree/main/airflow/config_templates
* docstrings updated to explain the behaviour
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexInhert commented on a change in pull request #18610: fixed default value of execution_timeout in base operator
Posted by GitBox <gi...@apache.org>.
alexInhert commented on a change in pull request #18610:
URL: https://github.com/apache/airflow/pull/18610#discussion_r718770145
##########
File path: airflow/models/baseoperator.py
##########
@@ -502,7 +502,7 @@ def __init__(
pool: Optional[str] = None,
pool_slots: int = 1,
sla: Optional[timedelta] = None,
- execution_timeout: Optional[timedelta] = None,
+ execution_timeout: Optional[timedelta] = conf.gettimedelta('core', 'default_ execution_timeout', fallback=None),
Review comment:
there is no `gettimedelta` function in https://github.com/apache/airflow/blob/main/airflow/configuration.py . You need to implement it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Ayushsunny commented on a change in pull request #18610: fixed default value of execution_timeout in base operator
Posted by GitBox <gi...@apache.org>.
Ayushsunny commented on a change in pull request #18610:
URL: https://github.com/apache/airflow/pull/18610#discussion_r729032457
##########
File path: airflow/models/baseoperator.py
##########
@@ -502,7 +502,7 @@ def __init__(
pool: Optional[str] = None,
pool_slots: int = 1,
sla: Optional[timedelta] = None,
- execution_timeout: Optional[timedelta] = None,
+ execution_timeout: Optional[timedelta] = conf.gettimedelta('core', 'default_ execution_timeout', fallback=None),
Review comment:
@zevaverbach Yeah, Sir sure take it as I'm busy with my University works.
Thank You.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zevaverbach commented on a change in pull request #18610: fixed default value of execution_timeout in base operator
Posted by GitBox <gi...@apache.org>.
zevaverbach commented on a change in pull request #18610:
URL: https://github.com/apache/airflow/pull/18610#discussion_r728310523
##########
File path: airflow/models/baseoperator.py
##########
@@ -502,7 +502,7 @@ def __init__(
pool: Optional[str] = None,
pool_slots: int = 1,
sla: Optional[timedelta] = None,
- execution_timeout: Optional[timedelta] = None,
+ execution_timeout: Optional[timedelta] = conf.gettimedelta('core', 'default_ execution_timeout', fallback=None),
Review comment:
I'd like to take this task over if @Ayushsunny is okay with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18610: fixed default value of execution_timeout in base operator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18610:
URL: https://github.com/apache/airflow/pull/18610#issuecomment-930355451
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18610: fixed default value of execution_timeout in base operator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18610:
URL: https://github.com/apache/airflow/pull/18610#issuecomment-930355451
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org