You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jamesnetherton (via GitHub)" <gi...@apache.org> on 2024/06/24 10:17:14 UTC
[PR] CAMEL-20901: Add an option to provide a custom Vertx instance to ArangoDB [camel]
jamesnetherton opened a new pull request, #14627:
URL: https://github.com/apache/camel/pull/14627
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20901: Add an option to provide a custom Vertx instance to ArangoDB [camel]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #14627:
URL: https://github.com/apache/camel/pull/14627#issuecomment-2186199673
/component-test arangodb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20901: Add an option to provide a custom Vertx instance to ArangoDB [camel]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton merged PR #14627:
URL: https://github.com/apache/camel/pull/14627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20901: Add an option to provide a custom Vertx instance to ArangoDB [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14627:
URL: https://github.com/apache/camel/pull/14627#issuecomment-2186237177
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20901: Add an option to provide a custom Vertx instance to ArangoDB [camel]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #14627:
URL: https://github.com/apache/camel/pull/14627#issuecomment-2186236327
/component-test arangodb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20901: Add an option to provide a custom Vertx instance to ArangoDB [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14627:
URL: https://github.com/apache/camel/pull/14627#issuecomment-2186195063
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20901: Add an option to provide a custom Vertx instance to ArangoDB [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #14627:
URL: https://github.com/apache/camel/pull/14627#discussion_r1650767008
##########
components/camel-arangodb/src/main/java/org/apache/camel/component/arangodb/ArangoDbComponent.java:
##########
@@ -31,6 +32,8 @@ public class ArangoDbComponent extends DefaultComponent {
@Metadata(label = "advanced", autowired = true)
private ArangoDB arangoDB;
+ @Metadata(label = "advanced")
Review Comment:
I think it should be autowired = true, then its automatic uses the one from Quarkus out of the box
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20901: Add an option to provide a custom Vertx instance to ArangoDB [camel]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #14627:
URL: https://github.com/apache/camel/pull/14627#discussion_r1650789286
##########
components/camel-arangodb/src/main/java/org/apache/camel/component/arangodb/ArangoDbComponent.java:
##########
@@ -31,6 +32,8 @@ public class ArangoDbComponent extends DefaultComponent {
@Metadata(label = "advanced", autowired = true)
private ArangoDB arangoDB;
+ @Metadata(label = "advanced")
Review Comment:
Thanks - Latest commit adds this. I verified it on the CQ side too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20901: Add an option to provide a custom Vertx instance to ArangoDB [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14627:
URL: https://github.com/apache/camel/pull/14627#issuecomment-2186200447
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org