You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2020/05/16 21:49:31 UTC
[GitHub] [struts-archetypes] JCgH4164838Gh792C124B5 opened a new pull request #6: Minor archetype fixes for generated project unit tests
JCgH4164838Gh792C124B5 opened a new pull request #6:
URL: https://github.com/apache/struts-archetypes/pull/6
Minor archetype fixes:
- Allow the unit tests for projects built from the Angular and Convention archetypes to run under JDK 11 (issue not seen with JDK8).
- Fix broken unit test for projects built from Blank archetype.
- Fix broken unit test for projects built from Convention archetype.
- Fix comment typo in HelloAction for the Convention archetype.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts-archetypes] hikaen2 commented on pull request #6: Minor archetype fixes for generated project unit tests
Posted by GitBox <gi...@apache.org>.
hikaen2 commented on pull request #6:
URL: https://github.com/apache/struts-archetypes/pull/6#issuecomment-706894350
> Allow the unit tests for projects built from the Angular and Convention archetypes to run under JDK 11 (issue not seen with JDK8).
In `mvn test` or `mvn jetty:run`, org.apache.struts2.convention.PackageBasedActionConfigBuilder#getActionAnnotations receives parameter "class org.apache.logging.log4j.core.appender.rolling.action.CommonsCompressAction".
If there is no commons-compress in pom.xml, NoClassDefFoundError will be thrown.
Is this correct behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts-archetypes] JCgH4164838Gh792C124B5 commented on pull request #6: Minor archetype fixes for generated project unit tests
Posted by GitBox <gi...@apache.org>.
JCgH4164838Gh792C124B5 commented on pull request #6:
URL: https://github.com/apache/struts-archetypes/pull/6#issuecomment-707364557
Hello @hikaen2 .
I am not sure if it is considered correct behaviour or not, but what you report seems to indicate that `commons-compress` may also be a `runtime` scope dependency for newer JDKs (like JDK 11) and the Conventions archetype, and not just a `test` scope dependency.
If that is the case, then the Conventions archetype should probably have the `commons-compress` dependency modified from `test `to `runtime`. @lukaszlenart , what do you think ?
If declaring `commons-compress` in `pom.xml` as a `runtime` dependency for the project seems to work, it sounds like it may be the only option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts-archetypes] lukaszlenart commented on pull request #6: Minor archetype fixes for generated project unit tests
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on pull request #6:
URL: https://github.com/apache/struts-archetypes/pull/6#issuecomment-707558592
@JCgH4164838Gh792C124B5 thanks a lot and I think you are right, changing scope is the only option for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts-archetypes] JCgH4164838Gh792C124B5 commented on pull request #6: Minor archetype fixes for generated project unit tests
Posted by GitBox <gi...@apache.org>.
JCgH4164838Gh792C124B5 commented on pull request #6:
URL: https://github.com/apache/struts-archetypes/pull/6#issuecomment-629711361
Hello Apache Struts Team.
This PR should fix a few minor issues with the unit tests failing in a few of the projects generated from the struts2-archetypes.
The "JDK11 only" test dependency for the projects built from the Angular and Convention archetypes (must declare a test-scope dependency on `commons-compress`) is weird, but applying it makes things work for both JDK 8 and JDK 11. If someone can see why this situation arises, please feel free to let others know in a comment. 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts-archetypes] hikaen2 edited a comment on pull request #6: Minor archetype fixes for generated project unit tests
Posted by GitBox <gi...@apache.org>.
hikaen2 edited a comment on pull request #6:
URL: https://github.com/apache/struts-archetypes/pull/6#issuecomment-706894350
> https://github.com/apache/struts-archetypes/commit/8aae883fa5a50ef6b2a0f336705ebcf396de3cc7#diff-019fb6a527487bb473675a65a0fc046e0b87a1427175d94678d7b4bd20af6417R70
> Allow the unit tests for projects built from the Angular and Convention archetypes to run under JDK 11 (issue not seen with JDK8).
In `mvn test` or `mvn jetty:run`, org.apache.struts2.convention.PackageBasedActionConfigBuilder#getActionAnnotations receives parameter "class org.apache.logging.log4j.core.appender.rolling.action.CommonsCompressAction".
If there is no commons-compress in pom.xml, NoClassDefFoundError will be thrown.
Is this correct behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts-archetypes] hikaen2 edited a comment on pull request #6: Minor archetype fixes for generated project unit tests
Posted by GitBox <gi...@apache.org>.
hikaen2 edited a comment on pull request #6:
URL: https://github.com/apache/struts-archetypes/pull/6#issuecomment-706894350
> https://github.com/apache/struts-archetypes/pull/6/commits/8aae883fa5a50ef6b2a0f336705ebcf396de3cc7#diff-1255c4d00c12aa187507b171595fb7a9R70
> Allow the unit tests for projects built from the Angular and Convention archetypes to run under JDK 11 (issue not seen with JDK8).
In `mvn test` or `mvn jetty:run`, org.apache.struts2.convention.PackageBasedActionConfigBuilder#getActionAnnotations receives parameter "class org.apache.logging.log4j.core.appender.rolling.action.CommonsCompressAction".
If there is no commons-compress in pom.xml, NoClassDefFoundError will be thrown.
Is this correct behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts-archetypes] lukaszlenart merged pull request #6: Minor archetype fixes for generated project unit tests
Posted by GitBox <gi...@apache.org>.
lukaszlenart merged pull request #6:
URL: https://github.com/apache/struts-archetypes/pull/6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org