You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/08 23:59:02 UTC
[GitHub] [spark] beliefer commented on a change in pull request #27497:
[SPARK-30245][SQL][FOLLOWUP] Improve regex expression when pattern not
changed
beliefer commented on a change in pull request #27497: [SPARK-30245][SQL][FOLLOWUP] Improve regex expression when pattern not changed
URL: https://github.com/apache/spark/pull/27497#discussion_r376742473
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -54,9 +54,20 @@ trait StringRegexExpression extends Expression
Pattern.compile(escape(str))
}
+ var lastPatternStr: String = null
Review comment:
Of course,I can do like this. I just followed the way of `RegExpExtract` and `RegExpReplace` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org