[Impala-ASF-CR] [stress] pull out QueryRunner

["Tim Armstrong (Code Review)" <ge...@cloudera.org>]

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12578 )

Change subject: [stress] pull out QueryRunner
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12578/2/tests/stress/query_runner.py
File tests/stress/query_runner.py:

http://gerrit.cloudera.org:8080/#/c/12578/2/tests/stress/query_runner.py@79
PS2, Line 79:     # TODO: other classes reach in and touch _metrics
I fixed this, can remove the TODO


http://gerrit.cloudera.org:8080/#/c/12578/2/tests/stress/query_runner.py@279
PS2, Line 279:   def _hash_result(self, cursor, timeout_unix_time, query):
This function is hideously long. I moved it untouched and will clean up in a follow-on patch.



-- 
To view, visit http://gerrit.cloudera.org:8080/12578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb
Gerrit-Change-Number: 12578
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 18:44:11 +0000
Gerrit-HasComments: Yes