[jira] [Closed] (GEODE-6219) NetstatDUnitTest is not not detecting failures in executing OS netstat command

["Owen Nichols (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GEODE-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen Nichols closed GEODE-6219.
-------------------------------

> NetstatDUnitTest is not not detecting failures in executing OS netstat command
> ------------------------------------------------------------------------------
>
>                 Key: GEODE-6219
>                 URL: https://issues.apache.org/jira/browse/GEODE-6219
>             Project: Geode
>          Issue Type: Bug
>          Components: ci, gfsh, tests
>    Affects Versions: 1.7.0
>            Reporter: Kenneth Howe
>            Assignee: Kenneth Howe
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.9.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> The tests in {{NetstatDUnitTest}} are all passing in CI. However, the logs show that the OS command that is run on the servers in the cluster is failing:
> {code}
> Command result for <netstat --with-lsof=true --file=/tmp/junit5019199898297364101/junit8715261921376128635/command.log.txt>: 
> Saved netstat output in the file /tmp/junit5019199898297364101/junit8715261921376128635/command.log.txt.
> Command result for <netstat>: 
> ##################################################
> Host: 1dcb8055baac
> OS: Linux 4.9.0-8-amd64 amd64
> Member(s):
>  server-1, locator-0, server-2
> ##################################################
> Could not execute "netstat". Reason: Cannot run program "netstat": error=2, No such file or directory
> {code}
> That {{netstat}} is missing from the CI test workers is being addressed in PR#3014. 
> The {{netstat}} tests need to verify the the OS commands run, in addition to verifying that the gfsh command tried to run on the expected servers.
> Suggest adding a check such as:
> {code}
> @@ -168,20 +187,24 @@ public class NetstatDUnitTest {
>    @Test
>    public void testConnectToLocatorWithLargeCommandResponse() throws Exception {
>      gfsh.connect(server0.getEmbeddedLocatorPort(), GfshCommandRule.PortType.locator);
> -    gfsh.executeAndAssertThat(netStatLsofCommand).statusIsSuccess();
> +    gfsh.executeAndAssertThat(netStatLsofCommand).statusIsSuccess()
> +        .doesNotContainOutput("Could not execute");
>    }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)