You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/11/11 15:08:06 UTC

[GitHub] [cordova-docs] raphinesse edited a comment on issue #1015: chore: remove translation

raphinesse edited a comment on issue #1015: chore: remove translation
URL: https://github.com/apache/cordova-docs/pull/1015#issuecomment-550066547
 
 
   Regarding your request for changes @dblotsky:
   
   > Redirecting to 404 would be a pretty awful experience.
   
   Agreed.
   
   > I think obsoleting all translations is a big enough deal that we should:
   > 1. Announce it (e.g. in a blog post),
   
   That would definitely be great to have.
   
   > 2. Come up with a new redirect page, specifically for language deprecation.
   
   Here I would go with what @janpio proposed:
   
   > Here it would probably make sense to redirect to the EN version of everything.
   
   I think this is more helpful than a redirect to a deprecation message. And it's very easy to implement. The following snippet added to [`www/.htaccess`](https://github.com/apache/cordova-docs/blob/d0890966b46655bbdeb8f2bf980b09a1f5bef525/www/.htaccess#L75) _should_ do the job (_untested_):
   
   ```apache
   # Redirect all docs translations to their English version
   RewriteCond $1 !=en
   RewriteRule ^.*docs/(\w\w(?:-\w\w)?)/(.*)$ {{site.baseurl}}/docs/en/$2 [R=301,L]
   ```
   
   > 3. Have a roadmap to change the build system not to build for all those languages.
   
   IMHO, that is a matter of creating an issue titled _Remove language support from build system_ but should not block us from going live with these changes. It can be addressed when someone finds the time to do so.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org