[freemarker] branch 2.3-gae updated: replace String by StringBuilder in ElementModel

[dd...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ddekany pushed a commit to branch 2.3-gae
in repository https://gitbox.apache.org/repos/asf/freemarker.git


The following commit(s) were added to refs/heads/2.3-gae by this push:
     new 8b811021 replace String by StringBuilder in ElementModel
     new 1ac8b9c1 Merge pull request #82 from GVDV/2.3-gae-fix
8b811021 is described below

commit 8b81102150ccfbec04f21fe35e453e229e390b4e
Author: Gert Van der Voorde <ge...@benerail.com>
AuthorDate: Mon Jun 13 09:13:16 2022 +0200

    replace String by StringBuilder in ElementModel
---
 src/main/java/freemarker/ext/dom/ElementModel.java | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/main/java/freemarker/ext/dom/ElementModel.java b/src/main/java/freemarker/ext/dom/ElementModel.java
index 09753521..8e3acae6 100644
--- a/src/main/java/freemarker/ext/dom/ElementModel.java
+++ b/src/main/java/freemarker/ext/dom/ElementModel.java
@@ -131,21 +131,21 @@ class ElementModel extends NodeModel implements TemplateScalarModel {
     @Override
     public String getAsString() throws TemplateModelException {
         NodeList nl = node.getChildNodes();
-        String result = "";
+        StringBuilder result = new StringBuilder();
         for (int i = 0; i < nl.getLength(); i++) {
             Node child = nl.item(i);
             int nodeType = child.getNodeType();
             if (nodeType == Node.ELEMENT_NODE) {
                 String msg = "Only elements with no child elements can be processed as text."
-                             + "\nThis element with name \""
-                             + node.getNodeName()
-                             + "\" has a child element named: " + child.getNodeName();
+                        + "\nThis element with name \""
+                        + node.getNodeName()
+                        + "\" has a child element named: " + child.getNodeName();
                 throw new TemplateModelException(msg);
             } else if (nodeType == Node.TEXT_NODE || nodeType == Node.CDATA_SECTION_NODE) {
-                result += child.getNodeValue();
+                result.append(child.getNodeValue());
             }
         }
-        return result;
+        return result.toString();
     }
     
     @Override