You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "manueljishi (via GitHub)" <gi...@apache.org> on 2025/11/25 14:34:07 UTC
[PR] Add trusted_addresses option to apisix configmap template [apisix-helm-chart]
manueljishi opened a new pull request, #909:
URL: https://github.com/apache/apisix-helm-chart/pull/909
This PR builds on top of #900 to enable trusted_addresses option and bump chart version for automatic deployment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add trusted_addresses option to apisix configmap template [apisix-helm-chart]
Posted by "manueljishi (via GitHub)" <gi...@apache.org>.
manueljishi commented on code in PR #909:
URL: https://github.com/apache/apisix-helm-chart/pull/909#discussion_r2560841052
##########
charts/apisix/README.md:
##########
@@ -128,6 +128,7 @@ The command removes all the Kubernetes components associated with the chart and
| apisix.status.ip | string | `"0.0.0.0"` | |
| apisix.status.port | int | `7085` | |
| apisix.stream_plugins | list | `[]` | Customize the list of APISIX stream_plugins to enable. By default, APISIX's [default stream_plugins](https://github.com/apache/apisix/blob/master/apisix/cli/config.lua#L294) are automatically used. |
+| apisix.trustedAddresses[0] | string | `"127.0.0.1"` | |
Review Comment:
I see, will adapt the changes in a sec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add trusted_addresses option to apisix configmap template [apisix-helm-chart]
Posted by "bzp2010 (via GitHub)" <gi...@apache.org>.
bzp2010 commented on PR #909:
URL: https://github.com/apache/apisix-helm-chart/pull/909#issuecomment-3576387422
BTW, you'll also need to run the `make helm-docs` to update the documentation. Simply execute the command and commit the changes; this will resolve the CI errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add trusted_addresses option to apisix configmap template [apisix-helm-chart]
Posted by "bzp2010 (via GitHub)" <gi...@apache.org>.
bzp2010 commented on code in PR #909:
URL: https://github.com/apache/apisix-helm-chart/pull/909#discussion_r2560509399
##########
charts/apisix/values.yaml:
##########
@@ -585,6 +585,10 @@ apisix:
ip: "0.0.0.0"
port: 7085
+ trusted_addresses:
+ - 127.0.0.1
+ - 172.18.0.0/16
Review Comment:
The `172.18.0.0/16` does not appear suitable as one of the default values. I believe we can keep only `127.0.0.1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add trusted_addresses option to apisix configmap template [apisix-helm-chart]
Posted by "manueljishi (via GitHub)" <gi...@apache.org>.
manueljishi commented on code in PR #909:
URL: https://github.com/apache/apisix-helm-chart/pull/909#discussion_r2560928442
##########
charts/apisix/README.md:
##########
@@ -128,6 +128,7 @@ The command removes all the Kubernetes components associated with the chart and
| apisix.status.ip | string | `"0.0.0.0"` | |
| apisix.status.port | int | `7085` | |
| apisix.stream_plugins | list | `[]` | Customize the list of APISIX stream_plugins to enable. By default, APISIX's [default stream_plugins](https://github.com/apache/apisix/blob/master/apisix/cli/config.lua#L294) are automatically used. |
+| apisix.trustedAddresses[0] | string | `"127.0.0.1"` | |
Review Comment:
@ngclinflows as you said, after the comment, the docs show the correct type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add trusted_addresses option to apisix configmap template [apisix-helm-chart]
Posted by "dennispan (via GitHub)" <gi...@apache.org>.
dennispan commented on code in PR #909:
URL: https://github.com/apache/apisix-helm-chart/pull/909#discussion_r2560721308
##########
charts/apisix/README.md:
##########
@@ -128,6 +128,7 @@ The command removes all the Kubernetes components associated with the chart and
| apisix.status.ip | string | `"0.0.0.0"` | |
| apisix.status.port | int | `7085` | |
| apisix.stream_plugins | list | `[]` | Customize the list of APISIX stream_plugins to enable. By default, APISIX's [default stream_plugins](https://github.com/apache/apisix/blob/master/apisix/cli/config.lua#L294) are automatically used. |
+| apisix.trustedAddresses[0] | string | `"127.0.0.1"` | |
Review Comment:
```suggestion
| apisix.trustedAddresses | list | `["127.0.0.1"]` | |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add trusted_addresses option to apisix configmap template [apisix-helm-chart]
Posted by "dennispan (via GitHub)" <gi...@apache.org>.
dennispan commented on code in PR #909:
URL: https://github.com/apache/apisix-helm-chart/pull/909#discussion_r2560726994
##########
charts/apisix/values.yaml:
##########
@@ -585,6 +585,10 @@ apisix:
ip: "0.0.0.0"
port: 7085
+ trusted_addresses:
+ - 127.0.0.1
+ - 172.18.0.0/16
Review Comment:
It's potentially a breaking change to users, who previously didn't want to set trusted addresses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add trusted_addresses option to apisix configmap template [apisix-helm-chart]
Posted by "dennispan (via GitHub)" <gi...@apache.org>.
dennispan commented on code in PR #909:
URL: https://github.com/apache/apisix-helm-chart/pull/909#discussion_r2560582234
##########
charts/apisix/templates/configmap.yaml:
##########
@@ -176,6 +176,11 @@ data:
port: {{ default "7085" (.Values.apisix.status.port | toString) }}
{{- end}}
+ {{ if .Values.apisix.trusted_addresses }}
+ trusted_addresses:
+ {{- toYaml .Values.apisix.trusted_addresses | nindent 8 }}
Review Comment:
```suggestion
{{- toYaml .Values.apisix.trustedAddresses | nindent 8 }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add trusted_addresses option to apisix configmap template [apisix-helm-chart]
Posted by "ngclinflows (via GitHub)" <gi...@apache.org>.
ngclinflows commented on code in PR #909:
URL: https://github.com/apache/apisix-helm-chart/pull/909#discussion_r2560782736
##########
charts/apisix/README.md:
##########
@@ -128,6 +128,7 @@ The command removes all the Kubernetes components associated with the chart and
| apisix.status.ip | string | `"0.0.0.0"` | |
| apisix.status.port | int | `7085` | |
| apisix.stream_plugins | list | `[]` | Customize the list of APISIX stream_plugins to enable. By default, APISIX's [default stream_plugins](https://github.com/apache/apisix/blob/master/apisix/cli/config.lua#L294) are automatically used. |
+| apisix.trustedAddresses[0] | string | `"127.0.0.1"` | |
Review Comment:
According to https://github.com/norwoodj/helm-docs, I think it was auto-generated. Adding a comment as I suggested will resolve this.
Documentation quote:
> The following rules are used to determine which values will be added to the values table in the README:
> * By default, only leaf nodes, that is, fields of type int, string, float, bool, empty lists, and empty maps are added as rows in the values table. These fields will be added even if they do not have a description comment
> * Lists and maps which contain elements will not be added as rows in the values table **unless they have a description comment which refers to them**
> * Adding a description comment for a non-empty list or map in this way makes it so that leaf nodes underneath the described field will not be automatically added to the values table. In order to document both a non-empty list/map and a leaf node within that field, description comments must be added for both
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add trusted_addresses option to apisix configmap template [apisix-helm-chart]
Posted by "manueljishi (via GitHub)" <gi...@apache.org>.
manueljishi commented on code in PR #909:
URL: https://github.com/apache/apisix-helm-chart/pull/909#discussion_r2560762512
##########
charts/apisix/README.md:
##########
@@ -128,6 +128,7 @@ The command removes all the Kubernetes components associated with the chart and
| apisix.status.ip | string | `"0.0.0.0"` | |
| apisix.status.port | int | `7085` | |
| apisix.stream_plugins | list | `[]` | Customize the list of APISIX stream_plugins to enable. By default, APISIX's [default stream_plugins](https://github.com/apache/apisix/blob/master/apisix/cli/config.lua#L294) are automatically used. |
+| apisix.trustedAddresses[0] | string | `"127.0.0.1"` | |
Review Comment:
Is this auto generated or manually edited?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add trusted_addresses option to apisix configmap template [apisix-helm-chart]
Posted by "ngclinflows (via GitHub)" <gi...@apache.org>.
ngclinflows commented on code in PR #909:
URL: https://github.com/apache/apisix-helm-chart/pull/909#discussion_r2560750582
##########
charts/apisix/values.yaml:
##########
@@ -585,6 +585,9 @@ apisix:
ip: "0.0.0.0"
port: 7085
+ trustedAddresses:
Review Comment:
```suggestion
# -- When configured, APISIX will trust the `X-Forwarded-*` Headers passed in requests from the IP/CIDR in the list.
trustedAddresses:
```
##########
charts/apisix/values.yaml:
##########
@@ -585,6 +585,9 @@ apisix:
ip: "0.0.0.0"
port: 7085
+ trustedAddresses:
Review Comment:
Then run `make helm-docs` again like @bzp2010 proposed. This will add the comment as a description in the `README.md` file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add trusted_addresses option to apisix configmap template [apisix-helm-chart]
Posted by "dennispan (via GitHub)" <gi...@apache.org>.
dennispan commented on code in PR #909:
URL: https://github.com/apache/apisix-helm-chart/pull/909#discussion_r2560586177
##########
charts/apisix/values.yaml:
##########
@@ -585,6 +585,10 @@ apisix:
ip: "0.0.0.0"
port: 7085
+ trusted_addresses:
+ - 127.0.0.1
+ - 172.18.0.0/16
Review Comment:
Do we need defaults? Should we just use empty list as default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add trusted_addresses option to apisix configmap template [apisix-helm-chart]
Posted by "manueljishi (via GitHub)" <gi...@apache.org>.
manueljishi commented on code in PR #909:
URL: https://github.com/apache/apisix-helm-chart/pull/909#discussion_r2560672442
##########
charts/apisix/values.yaml:
##########
@@ -585,6 +585,10 @@ apisix:
ip: "0.0.0.0"
port: 7085
+ trusted_addresses:
+ - 127.0.0.1
+ - 172.18.0.0/16
Review Comment:
I believe since this is an opt-out feature, some default values may make it more visible for the end user. So I'd leave some default values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add trusted_addresses option to apisix configmap template [apisix-helm-chart]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop merged PR #909:
URL: https://github.com/apache/apisix-helm-chart/pull/909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org