[GitHub] [solr] noblepaul commented on a diff in pull request #1242: SOLR-16580: Avoid making copies of DocCollection for PRS updates

[GitBox <gi...@apache.org>]

noblepaul commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1060910294


##########
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##########
@@ -139,30 +138,10 @@ public static String getCollectionPathRoot(String coll) {
    * only a replica is updated
    */
   public DocCollection copyWith(PerReplicaStates newPerReplicaStates) {

Review Comment:
   The `DocCollection` , all the Slices & Replicas share the same `PrsSupplier`. When the PRS data changes, it's immediately visible to all the objects at once



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org