You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2024/07/01 11:37:54 UTC

[Impala-ASF-CR] IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s

Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21557 )

Change subject: IMPALA-13088: Use RoaringBitmap instead of sorted vector of int64s
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21557/2/bin/rat_exclude_files.txt
File bin/rat_exclude_files.txt:

http://gerrit.cloudera.org:8080/#/c/21557/2/bin/rat_exclude_files.txt@245
PS2, Line 245: be/src/thirdparty/roaring/LICENSE
Shouldn't we add the licence to /LICENSE.txt, as the comment above writes?



-- 
To view, visit http://gerrit.cloudera.org:8080/21557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib769965d094149e99c43e0044914d9ecccc76107
Gerrit-Change-Number: 21557
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jul 2024 11:37:54 +0000
Gerrit-HasComments: Yes