[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42887: [SPARK-45130][CONNECT][ML][PYTHON] Avoid Spark connect ML model to change input pandas dataframe

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #42887:
URL: https://github.com/apache/spark/pull/42887#discussion_r1324374381


##########
python/pyspark/ml/tests/connect/test_legacy_mode_classification.py:
##########
@@ -19,6 +19,7 @@
 import tempfile
 import unittest
 import numpy as np
+import pandas as pd

Review Comment:
   can you import this within `test_binary_classes_logistic_regression` or under `should_test_connect` so the tests can be skipped fine when `pandas` is not installed?



##########
python/pyspark/ml/tests/connect/test_legacy_mode_feature.py:
##########
@@ -19,6 +19,7 @@
 import os
 import pickle
 import numpy as np
+import pandas as pd

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org