You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2021/10/06 12:13:47 UTC
[GitHub] [jackrabbit-oak] stefan-egli commented on a change in pull request #385: OAK-9592 - Log exceptions when retrying find
stefan-egli commented on a change in pull request #385:
URL: https://github.com/apache/jackrabbit-oak/pull/385#discussion_r723179376
##########
File path: oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java
##########
@@ -550,6 +550,8 @@ public NodeDocument call() throws Exception {
return findUncached(collection, key, docReadPref);
} catch (MongoException e) {
ex = e;
+ LOG.error("Read Fails with an exception" + e);
+ e.printStackTrace();
Review comment:
would adding the exception stacktrace to the log make sense or is that too verbose? (e.printStackTrace() otherwise just prints to standard out)
##########
File path: oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java
##########
@@ -550,6 +550,8 @@ public NodeDocument call() throws Exception {
return findUncached(collection, key, docReadPref);
} catch (MongoException e) {
ex = e;
+ LOG.error("Read Fails with an exception" + e);
+ e.printStackTrace();
Review comment:
```suggestion
LOG.error("findUncachedWithRetry : read fails with an exception" + e, e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org