You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/20 15:47:16 UTC

[GitHub] [flink] TisonKun commented on a change in pull request #9726: [FLINK-14113][client] Remove class JobWithJars

TisonKun commented on a change in pull request #9726: [FLINK-14113][client] Remove class JobWithJars
URL: https://github.com/apache/flink/pull/9726#discussion_r326691424
 
 

 ##########
 File path: flink-clients/src/main/java/org/apache/flink/client/ClientUtils.java
 ##########
 @@ -124,6 +47,7 @@ public static void checkJarFile(URL jar) throws IOException {
 			throw new IOException("JAR file can't be read '" + jarFile.getAbsolutePath() + '\'');
 		}
 
+		//noinspection EmptyTryBlock
 
 Review comment:
   Thanks for your information. I think it is not a warning for java compiler. Besides, we over 100 usages of `//noinspection`. I'm ok to revert this line fair enough but it might be worth a community discussion :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services