[GitHub] [maven-surefire] shark-horse commented on issue #231: Failsafe: Killing self fork JVM. PING timeout elapsed.

[GitBox <gi...@apache.org>]

shark-horse commented on issue #231: Failsafe: Killing self fork JVM. PING timeout elapsed.
URL: https://github.com/apache/maven-surefire/pull/231#issuecomment-485513514
 
 
   Thanks for doing this.
   
   I'm still thinking about ways to ensure (as much as possible, within the context of the Surefire process) that the CommandReader is allowed opportunity to read NOOP commands before the ping checker checks. Right now, the CommandReader reads from an InputStream in such a way that it does not know when it's exhausted everything in the stream thus far, but blocks for input. If instead it was a recurring, scheduled task in an executor that would only read everything in the input stream available at the time upon each execution, not only would that free up a thread in-between reads, but also it could record the last time it ran as well as the last time there _was_ a NOOP. Then the ping checker could consider everything OK if CommandReader did not have a chance to run.
   
   I know it's a lot easier for me to spout my ideas than for anyone to implement any of this. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services