You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ivan Zvolsky (JIRA)" <ji...@apache.org> on 2007/02/19 12:49:05 UTC
[jira] Created: (HARMONY-3198) [drlvm] several uncertain changes
need careful review
[drlvm] several uncertain changes need careful review
-----------------------------------------------------
Key: HARMONY-3198
URL: https://issues.apache.org/jira/browse/HARMONY-3198
Project: Harmony
Issue Type: Sub-task
Components: DRLVM
Environment: windows/em64t
Reporter: Ivan Zvolsky
drlvm_need_impl.patch also contains 3 somewhat questionable changes:
1) line 11: drlvm didn't compile with 'private' modifier under windows/em64t but compiler fine without. I workarounded this by removing it for windows/em64t, but the modifier certainly needs to be there.
2) line 28: same as above - the line must be uncommented, but I couldn't find the way to fix compilation problem quickly, so I removed the line for windows/em64t.
3) line 113: couldn't compile that "as is", so had to replace the line with something different, but i'm not sure they are equivalent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3198) [drlvm][winx64] several uncertain
changes need careful review
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky updated HARMONY-3198:
---------------------------------------
Summary: [drlvm][winx64] several uncertain changes need careful review (was: [drlvm] several uncertain changes need careful review)
> [drlvm][winx64] several uncertain changes need careful review
> -------------------------------------------------------------
>
> Key: HARMONY-3198
> URL: https://issues.apache.org/jira/browse/HARMONY-3198
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: windows/em64t
> Reporter: Ivan Zvolsky
> Assigned To: Gregory Shimansky
> Attachments: H3198.patch
>
>
> drlvm_need_impl.patch also contains 3 somewhat questionable changes:
> 1) line 11: drlvm didn't compile with 'private' modifier under windows/em64t but compiler fine without. I workarounded this by removing it for windows/em64t, but the modifier certainly needs to be there.
> 2) line 28: same as above - the line must be uncommented, but I couldn't find the way to fix compilation problem quickly, so I removed the line for windows/em64t.
> 3) line 113: couldn't compile that "as is", so had to replace the line with something different, but i'm not sure they are equivalent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-3198) [drlvm] several uncertain changes
need careful review
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky resolved HARMONY-3198.
----------------------------------------
Resolution: Fixed
Patch applied at 511551. Please check that it was applied as expected.
> [drlvm] several uncertain changes need careful review
> -----------------------------------------------------
>
> Key: HARMONY-3198
> URL: https://issues.apache.org/jira/browse/HARMONY-3198
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: windows/em64t
> Reporter: Ivan Zvolsky
> Assigned To: Gregory Shimansky
> Attachments: H3198.patch
>
>
> drlvm_need_impl.patch also contains 3 somewhat questionable changes:
> 1) line 11: drlvm didn't compile with 'private' modifier under windows/em64t but compiler fine without. I workarounded this by removing it for windows/em64t, but the modifier certainly needs to be there.
> 2) line 28: same as above - the line must be uncommented, but I couldn't find the way to fix compilation problem quickly, so I removed the line for windows/em64t.
> 3) line 113: couldn't compile that "as is", so had to replace the line with something different, but i'm not sure they are equivalent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-3198) [drlvm] several uncertain changes
need careful review
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky reassigned HARMONY-3198:
------------------------------------------
Assignee: Gregory Shimansky
> [drlvm] several uncertain changes need careful review
> -----------------------------------------------------
>
> Key: HARMONY-3198
> URL: https://issues.apache.org/jira/browse/HARMONY-3198
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: windows/em64t
> Reporter: Ivan Zvolsky
> Assigned To: Gregory Shimansky
> Attachments: H3198.patch
>
>
> drlvm_need_impl.patch also contains 3 somewhat questionable changes:
> 1) line 11: drlvm didn't compile with 'private' modifier under windows/em64t but compiler fine without. I workarounded this by removing it for windows/em64t, but the modifier certainly needs to be there.
> 2) line 28: same as above - the line must be uncommented, but I couldn't find the way to fix compilation problem quickly, so I removed the line for windows/em64t.
> 3) line 113: couldn't compile that "as is", so had to replace the line with something different, but i'm not sure they are equivalent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-3198) [drlvm][winx64] several uncertain
changes need careful review
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky closed HARMONY-3198.
--------------------------------------
No response, assuming ok.
> [drlvm][winx64] several uncertain changes need careful review
> -------------------------------------------------------------
>
> Key: HARMONY-3198
> URL: https://issues.apache.org/jira/browse/HARMONY-3198
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: windows/em64t
> Reporter: Ivan Zvolsky
> Assignee: Gregory Shimansky
> Attachments: H3198.patch
>
>
> drlvm_need_impl.patch also contains 3 somewhat questionable changes:
> 1) line 11: drlvm didn't compile with 'private' modifier under windows/em64t but compiler fine without. I workarounded this by removing it for windows/em64t, but the modifier certainly needs to be there.
> 2) line 28: same as above - the line must be uncommented, but I couldn't find the way to fix compilation problem quickly, so I removed the line for windows/em64t.
> 3) line 113: couldn't compile that "as is", so had to replace the line with something different, but i'm not sure they are equivalent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3198) [drlvm] several uncertain changes
need careful review
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Pervov updated HARMONY-3198:
----------------------------------
Attachment: H3198.patch
> [drlvm] several uncertain changes need careful review
> -----------------------------------------------------
>
> Key: HARMONY-3198
> URL: https://issues.apache.org/jira/browse/HARMONY-3198
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: windows/em64t
> Reporter: Ivan Zvolsky
> Attachments: H3198.patch
>
>
> drlvm_need_impl.patch also contains 3 somewhat questionable changes:
> 1) line 11: drlvm didn't compile with 'private' modifier under windows/em64t but compiler fine without. I workarounded this by removing it for windows/em64t, but the modifier certainly needs to be there.
> 2) line 28: same as above - the line must be uncommented, but I couldn't find the way to fix compilation problem quickly, so I removed the line for windows/em64t.
> 3) line 113: couldn't compile that "as is", so had to replace the line with something different, but i'm not sure they are equivalent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3198) [drlvm] several uncertain changes
need careful review
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475319 ]
Pavel Pervov commented on HARMONY-3198:
---------------------------------------
Attached patch fixes issues discovered.
> [drlvm] several uncertain changes need careful review
> -----------------------------------------------------
>
> Key: HARMONY-3198
> URL: https://issues.apache.org/jira/browse/HARMONY-3198
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Environment: windows/em64t
> Reporter: Ivan Zvolsky
> Attachments: H3198.patch
>
>
> drlvm_need_impl.patch also contains 3 somewhat questionable changes:
> 1) line 11: drlvm didn't compile with 'private' modifier under windows/em64t but compiler fine without. I workarounded this by removing it for windows/em64t, but the modifier certainly needs to be there.
> 2) line 28: same as above - the line must be uncommented, but I couldn't find the way to fix compilation problem quickly, so I removed the line for windows/em64t.
> 3) line 113: couldn't compile that "as is", so had to replace the line with something different, but i'm not sure they are equivalent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.