You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by ro...@apache.org on 2012/12/27 02:33:37 UTC
git commit: THRIFT-1779 Missing process_XXXX method in generated
TProcessor implementation for all 'oneway' service functions Patch: Luis
Laugga
Updated Branches:
refs/heads/master 19dbbefcc -> 6df4f3bbc
THRIFT-1779 Missing process_XXXX method in generated TProcessor implementation for all 'oneway' service functions
Patch: Luis Laugga
Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/6df4f3bb
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/6df4f3bb
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/6df4f3bb
Branch: refs/heads/master
Commit: 6df4f3bbc7d6b955d403ea1523b74f10047aa6ff
Parents: 19dbbef
Author: Roger Meier <ro...@apache.org>
Authored: Thu Dec 27 02:32:44 2012 +0100
Committer: Roger Meier <ro...@apache.org>
Committed: Thu Dec 27 02:32:44 2012 +0100
----------------------------------------------------------------------
compiler/cpp/src/generate/t_cocoa_generator.cc | 28 ++++++++++---------
1 files changed, 15 insertions(+), 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/thrift/blob/6df4f3bb/compiler/cpp/src/generate/t_cocoa_generator.cc
----------------------------------------------------------------------
diff --git a/compiler/cpp/src/generate/t_cocoa_generator.cc b/compiler/cpp/src/generate/t_cocoa_generator.cc
index 7e26ee2..3a7e2c1 100644
--- a/compiler/cpp/src/generate/t_cocoa_generator.cc
+++ b/compiler/cpp/src/generate/t_cocoa_generator.cc
@@ -1575,9 +1575,6 @@ void t_cocoa_generator::generate_cocoa_service_server_implementation(ofstream& o
// generate a process_XXXX method for each service function, which reads args, calls the service, and writes results
functions = tservice->get_functions();
for (f_iter = functions.begin(); f_iter != functions.end(); ++f_iter) {
- if ((*f_iter)->is_oneway()) {
- continue;
- }
out << endl;
string funname = (*f_iter)->get_name();
out << indent() << "- (void) process_" << funname << "_withSequenceID: (int32_t) seqID inProtocol: (id<TProtocol>) inProtocol outProtocol: (id<TProtocol>) outProtocol" << endl;
@@ -1587,8 +1584,11 @@ void t_cocoa_generator::generate_cocoa_service_server_implementation(ofstream& o
out << indent() << "[args read: inProtocol];" << endl;
out << indent() << "[inProtocol readMessageEnd];" << endl;
- string resulttype = cocoa_prefix_ + function_result_helper_struct_type(*f_iter);
- out << indent() << resulttype << " * result = [[" << resulttype << " alloc] init];" << endl;
+ // prepare the result if not oneway
+ if (!(*f_iter)->is_oneway()) {
+ string resulttype = cocoa_prefix_ + function_result_helper_struct_type(*f_iter);
+ out << indent() << resulttype << " * result = [[" << resulttype << " alloc] init];" << endl;
+ }
// make the call to the actual service object
out << indent();
@@ -1616,14 +1616,16 @@ void t_cocoa_generator::generate_cocoa_service_server_implementation(ofstream& o
}
out << ";" << endl;
- // write out the result
- out << indent() << "[outProtocol writeMessageBeginWithName: @\"" << funname << "\"" << endl;
- out << indent() << " type: TMessageType_REPLY" << endl;
- out << indent() << " sequenceID: seqID];" << endl;
- out << indent() << "[result write: outProtocol];" << endl;
- out << indent() << "[outProtocol writeMessageEnd];" << endl;
- out << indent() << "[[outProtocol transport] flush];" << endl;
- out << indent() << "[result release_stub];" << endl;
+ // write out the result if not oneway
+ if (!(*f_iter)->is_oneway()) {
+ out << indent() << "[outProtocol writeMessageBeginWithName: @\"" << funname << "\"" << endl;
+ out << indent() << " type: TMessageType_REPLY" << endl;
+ out << indent() << " sequenceID: seqID];" << endl;
+ out << indent() << "[result write: outProtocol];" << endl;
+ out << indent() << "[outProtocol writeMessageEnd];" << endl;
+ out << indent() << "[[outProtocol transport] flush];" << endl;
+ out << indent() << "[result release_stub];" << endl;
+ }
out << indent() << "[args release_stub];" << endl;
scope_down(out);