[GitHub] [apisix-dashboard] membphis commented on a change in pull request #958: feat: implement API to get apisix instances status

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #958:
URL: https://github.com/apache/apisix-dashboard/pull/958#discussion_r545565847



##########
File path: api/test/docker/apisix_config2.yaml
##########
@@ -93,4 +93,5 @@ plugin_attr:
 
   server-info:
     report_interval: 10
-    report_ttl: 3600
\ No newline at end of file
+    report_ttl: 3600
+

Review comment:
       we can remove `apisix.ssl. ssl_cert` and `apisix.ssl. ssl_cert_key`

##########
File path: api/test/docker/apisix_config2.yaml
##########
@@ -93,4 +93,5 @@ plugin_attr:
 
   server-info:
     report_interval: 10
-    report_ttl: 3600
\ No newline at end of file
+    report_ttl: 3600
+

Review comment:
       same issue with file `api/test/docker/apisix_config.yaml`

##########
File path: api/test/docker/apisix_config2.yaml
##########
@@ -93,4 +93,5 @@ plugin_attr:
 
   server-info:
     report_interval: 10
-    report_ttl: 3600
\ No newline at end of file
+    report_ttl: 3600
+

Review comment:
       and we can remove `plugins` too




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org