You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/27 10:36:14 UTC

[GitHub] [pulsar] zhaohaidao opened a new pull request, #18223: [fix][broker] Log pulsar service config except sensitive info at startup

zhaohaidao opened a new pull request, #18223:
URL: https://github.com/apache/pulsar/pull/18223

   ### Motivation
   Printing service configuration at startup can help us effectively troubleshoot problems, but after #14421, the configuration at startup is no longer displayed.
   According to the analysis, #14421 is mainly to avoid printing private information, such as passwords, rather than the entire configuration
   
   ### Modifications
   Log pulsar service config except sensitive info at startup
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   - [x] This change is a trivial rework / code cleanup without any test coverage.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: <!-- ENTER URL HERE -->
   
   <!--
   After opening this PR, the build in apache/pulsar will fail and instructions will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments have
   been handled, the tests pass and the PR is approved by a reviewer.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zhaohaidao closed pull request #18223: [fix][broker] Log pulsar service config except sensitive info at startup

Posted by GitBox <gi...@apache.org>.
zhaohaidao closed pull request #18223: [fix][broker] Log pulsar service config except sensitive info at startup
URL: https://github.com/apache/pulsar/pull/18223


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zhaohaidao commented on pull request #18223: [fix][broker] Log pulsar service config except sensitive info at startup

Posted by GitBox <gi...@apache.org>.
zhaohaidao commented on PR #18223:
URL: https://github.com/apache/pulsar/pull/18223#issuecomment-1293336005

   duplicate


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org