[GitHub] [arrow] pitrou commented on a diff in pull request #13249: ARROW-16674: [Java] C data interface: Reading as nioBuffer from imported buffer causes error

[GitBox <gi...@apache.org>]

pitrou commented on code in PR #13249:
URL: https://github.com/apache/arrow/pull/13249#discussion_r886962833


##########
java/c/src/test/java/org/apache/arrow/c/RoundtripTest.java:
##########
@@ -678,6 +679,22 @@ public void testSchema() {
     }
   }
 
+  @Test
+  public void testImportedBufferAsNioBuffer() {
+    IntVector imported;
+    try (final IntVector vector = new IntVector("v", allocator)) {
+      setVector(vector, 1, 2, 3, null);
+      imported = (IntVector) vectorRoundtrip(vector);
+      ArrowBuf dataBuffer = imported.getDataBuffer();
+      ByteBuffer nioBuffer = dataBuffer.nioBuffer().asReadOnlyBuffer();
+      nioBuffer.order(ByteOrder.nativeOrder());
+      assertEquals(1, nioBuffer.getInt(0));
+      assertEquals(2, nioBuffer.getInt(1 << 2));
+      assertEquals(3, nioBuffer.getInt(2 << 2));
+    }
+    imported.close();

Review Comment:
   Ok, my question was more along the lines of "wouldn't the garbage collector clear up any remaining resources anyway?".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org