You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by Julian Feinauer <j....@pragmaticminds.de> on 2020/03/02 09:55:37 UTC
Grafana Integration currently broken?
Hi all,
I just played around a bit with IoTDB-Grafana integration the last days and it seems that it works in 0.9.0 and 0.9.1 but is broken in the current master. It seems like the query there is not valid. I guess some refactoring was done but not properly tested.
Is anyone working on that currently?
Otherwise I would try to fix it the next days and provide an update.
Julian
Re: Grafana Integration currently broken?
Posted by Boris Zhu <zh...@gmail.com>.
I will develop a new grafana plugin after rest API.
On Mon, Mar 2, 2020 at 9:16 PM Jialin Qiao <qj...@mails.tsinghua.edu.cn>
wrote:
> Hi Julian,
>
> It seems that the line 89 in BasicDaoImpl.java
>
> statement.execute("show timeseries" + "root *");
>
> should be
>
> statement.execute("show timeseries");
>
> I have submitted a pr:
> https://github.com/apache/incubator-iotdb/pull/870
>
> Please have a check :)
>
> Thanks,
> --
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>
> > -----原始邮件-----
> > 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
> > 发送时间: 2020-03-02 20:35:37 (星期一)
> > 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
> > 抄送:
> > 主题: Re: Grafana Integration currently broken?
> >
> > Hi Jialin,
> >
> > building isnt the issue, it just don’t works feature wise : )
> > There are errors in the queries so it don’t shows data in Grafana.
> >
> > Sorry, I was unclear about that.
> >
> > Julian
> >
> > Am 02.03.20, 13:33 schrieb "Jialin Qiao" <qj...@mails.tsinghua.edu.cn>:
> >
> > Hi Julian,
> >
> > I could execute "mvn clean package -DskipTests" successfully
> including grafana.
> > What's the error for grafana integration you meet?
> >
> > Thanks,
> > --
> > Jialin Qiao
> > School of Software, Tsinghua University
> >
> > 乔嘉林
> > 清华大学 软件学院
> >
> > > -----原始邮件-----
> > > 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
> > > 发送时间: 2020-03-02 17:55:37 (星期一)
> > > 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
> > > 抄送:
> > > 主题: Grafana Integration currently broken?
> > >
> > > Hi all,
> > >
> > > I just played around a bit with IoTDB-Grafana integration the last
> days and it seems that it works in 0.9.0 and 0.9.1 but is broken in the
> current master. It seems like the query there is not valid. I guess some
> refactoring was done but not properly tested.
> > > Is anyone working on that currently?
> > > Otherwise I would try to fix it the next days and provide an
> update.
> > >
> > > Julian
> >
> >
>
Re: Grafana Integration currently broken?
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi,
I did not fully test it, swichted to 0.9.1 then : )
But, I will have another look.
As discussed with Xiangdong I'm currently working on an extension to automatically do group by if time range is too large, see discussion here https://issues.apache.org/jira/browse/IOTDB-528.
But I think it makes sense to rewrite the integration to make it ideally work with native Grafana without the need the modify the installation, big +1 for that.
Julian
Am 02.03.20, 16:25 schrieb "Xiangdong Huang" <sa...@gmail.com>:
Hi Julian and Jialin,
I have merged PR #865, and now it works on master branch.
Jialin, I will close your PR as it is duplicated with #865.
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Xiangdong Huang <sa...@gmail.com> 于2020年3月2日周一 下午11:00写道：
> Hi Jialin,
>
> Julian has fixed the bug in
> https://github.com/apache/incubator-iotdb/pull/865
>
> So is this the only issue? Have you tested the connector?
>
> Best,
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
>
>
> Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2020年3月2日周一 下午9:16写道：
>
>> Hi Julian,
>>
>> It seems that the line 89 in BasicDaoImpl.java
>>
>> statement.execute("show timeseries" + "root *");
>>
>> should be
>>
>> statement.execute("show timeseries");
>>
>> I have submitted a pr:
>> https://github.com/apache/incubator-iotdb/pull/870
>>
>> Please have a check :)
>>
>> Thanks,
>> --
>> Jialin Qiao
>> School of Software, Tsinghua University
>>
>> 乔嘉林
>> 清华大学 软件学院
>>
>> > -----原始邮件-----
>> > 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
>> > 发送时间: 2020-03-02 20:35:37 (星期一)
>> > 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
>> > 抄送:
>> > 主题: Re: Grafana Integration currently broken?
>> >
>> > Hi Jialin,
>> >
>> > building isnt the issue, it just don’t works feature wise : )
>> > There are errors in the queries so it don’t shows data in Grafana.
>> >
>> > Sorry, I was unclear about that.
>> >
>> > Julian
>> >
>> > Am 02.03.20, 13:33 schrieb "Jialin Qiao" <qjl16@mails.tsinghua.edu.cn
>> >:
>> >
>> > Hi Julian,
>> >
>> > I could execute "mvn clean package -DskipTests" successfully
>> including grafana.
>> > What's the error for grafana integration you meet?
>> >
>> > Thanks,
>> > --
>> > Jialin Qiao
>> > School of Software, Tsinghua University
>> >
>> > 乔嘉林
>> > 清华大学 软件学院
>> >
>> > > -----原始邮件-----
>> > > 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
>> > > 发送时间: 2020-03-02 17:55:37 (星期一)
>> > > 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
>> > > 抄送:
>> > > 主题: Grafana Integration currently broken?
>> > >
>> > > Hi all,
>> > >
>> > > I just played around a bit with IoTDB-Grafana integration the
>> last days and it seems that it works in 0.9.0 and 0.9.1 but is broken in
>> the current master. It seems like the query there is not valid. I guess
>> some refactoring was done but not properly tested.
>> > > Is anyone working on that currently?
>> > > Otherwise I would try to fix it the next days and provide an
>> update.
>> > >
>> > > Julian
>> >
>> >
>>
>
Re: Grafana Integration currently broken?
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi Julian and Jialin,
I have merged PR #865, and now it works on master branch.
Jialin, I will close your PR as it is duplicated with #865.
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Xiangdong Huang <sa...@gmail.com> 于2020年3月2日周一 下午11:00写道：
> Hi Jialin,
>
> Julian has fixed the bug in
> https://github.com/apache/incubator-iotdb/pull/865
>
> So is this the only issue? Have you tested the connector?
>
> Best,
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
>
>
> Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2020年3月2日周一 下午9:16写道：
>
>> Hi Julian,
>>
>> It seems that the line 89 in BasicDaoImpl.java
>>
>> statement.execute("show timeseries" + "root *");
>>
>> should be
>>
>> statement.execute("show timeseries");
>>
>> I have submitted a pr:
>> https://github.com/apache/incubator-iotdb/pull/870
>>
>> Please have a check :)
>>
>> Thanks,
>> --
>> Jialin Qiao
>> School of Software, Tsinghua University
>>
>> 乔嘉林
>> 清华大学 软件学院
>>
>> > -----原始邮件-----
>> > 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
>> > 发送时间: 2020-03-02 20:35:37 (星期一)
>> > 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
>> > 抄送:
>> > 主题: Re: Grafana Integration currently broken?
>> >
>> > Hi Jialin,
>> >
>> > building isnt the issue, it just don’t works feature wise : )
>> > There are errors in the queries so it don’t shows data in Grafana.
>> >
>> > Sorry, I was unclear about that.
>> >
>> > Julian
>> >
>> > Am 02.03.20, 13:33 schrieb "Jialin Qiao" <qjl16@mails.tsinghua.edu.cn
>> >:
>> >
>> > Hi Julian,
>> >
>> > I could execute "mvn clean package -DskipTests" successfully
>> including grafana.
>> > What's the error for grafana integration you meet?
>> >
>> > Thanks,
>> > --
>> > Jialin Qiao
>> > School of Software, Tsinghua University
>> >
>> > 乔嘉林
>> > 清华大学 软件学院
>> >
>> > > -----原始邮件-----
>> > > 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
>> > > 发送时间: 2020-03-02 17:55:37 (星期一)
>> > > 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
>> > > 抄送:
>> > > 主题: Grafana Integration currently broken?
>> > >
>> > > Hi all,
>> > >
>> > > I just played around a bit with IoTDB-Grafana integration the
>> last days and it seems that it works in 0.9.0 and 0.9.1 but is broken in
>> the current master. It seems like the query there is not valid. I guess
>> some refactoring was done but not properly tested.
>> > > Is anyone working on that currently?
>> > > Otherwise I would try to fix it the next days and provide an
>> update.
>> > >
>> > > Julian
>> >
>> >
>>
>
Re: Grafana Integration currently broken?
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi Jialin,
Julian has fixed the bug in
https://github.com/apache/incubator-iotdb/pull/865
So is this the only issue? Have you tested the connector?
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2020年3月2日周一 下午9:16写道：
> Hi Julian,
>
> It seems that the line 89 in BasicDaoImpl.java
>
> statement.execute("show timeseries" + "root *");
>
> should be
>
> statement.execute("show timeseries");
>
> I have submitted a pr:
> https://github.com/apache/incubator-iotdb/pull/870
>
> Please have a check :)
>
> Thanks,
> --
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>
> > -----原始邮件-----
> > 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
> > 发送时间: 2020-03-02 20:35:37 (星期一)
> > 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
> > 抄送:
> > 主题: Re: Grafana Integration currently broken?
> >
> > Hi Jialin,
> >
> > building isnt the issue, it just don’t works feature wise : )
> > There are errors in the queries so it don’t shows data in Grafana.
> >
> > Sorry, I was unclear about that.
> >
> > Julian
> >
> > Am 02.03.20, 13:33 schrieb "Jialin Qiao" <qj...@mails.tsinghua.edu.cn>:
> >
> > Hi Julian,
> >
> > I could execute "mvn clean package -DskipTests" successfully
> including grafana.
> > What's the error for grafana integration you meet?
> >
> > Thanks,
> > --
> > Jialin Qiao
> > School of Software, Tsinghua University
> >
> > 乔嘉林
> > 清华大学 软件学院
> >
> > > -----原始邮件-----
> > > 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
> > > 发送时间: 2020-03-02 17:55:37 (星期一)
> > > 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
> > > 抄送:
> > > 主题: Grafana Integration currently broken?
> > >
> > > Hi all,
> > >
> > > I just played around a bit with IoTDB-Grafana integration the last
> days and it seems that it works in 0.9.0 and 0.9.1 but is broken in the
> current master. It seems like the query there is not valid. I guess some
> refactoring was done but not properly tested.
> > > Is anyone working on that currently?
> > > Otherwise I would try to fix it the next days and provide an
> update.
> > >
> > > Julian
> >
> >
>
Re: Grafana Integration currently broken?
Posted by Jialin Qiao <qj...@mails.tsinghua.edu.cn>.
Hi Julian,
It seems that the line 89 in BasicDaoImpl.java
statement.execute("show timeseries" + "root *");
should be
statement.execute("show timeseries");
I have submitted a pr: https://github.com/apache/incubator-iotdb/pull/870
Please have a check :)
Thanks,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
> -----原始邮件-----
> 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
> 发送时间: 2020-03-02 20:35:37 (星期一)
> 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
> 抄送:
> 主题: Re: Grafana Integration currently broken?
>
> Hi Jialin,
>
> building isnt the issue, it just don’t works feature wise : )
> There are errors in the queries so it don’t shows data in Grafana.
>
> Sorry, I was unclear about that.
>
> Julian
>
> Am 02.03.20, 13:33 schrieb "Jialin Qiao" <qj...@mails.tsinghua.edu.cn>:
>
> Hi Julian,
>
> I could execute "mvn clean package -DskipTests" successfully including grafana.
> What's the error for grafana integration you meet?
>
> Thanks,
> --
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>
> > -----原始邮件-----
> > 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
> > 发送时间: 2020-03-02 17:55:37 (星期一)
> > 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
> > 抄送:
> > 主题: Grafana Integration currently broken?
> >
> > Hi all,
> >
> > I just played around a bit with IoTDB-Grafana integration the last days and it seems that it works in 0.9.0 and 0.9.1 but is broken in the current master. It seems like the query there is not valid. I guess some refactoring was done but not properly tested.
> > Is anyone working on that currently?
> > Otherwise I would try to fix it the next days and provide an update.
> >
> > Julian
>
>
Re: Grafana Integration currently broken?
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi Jialin,
building isnt the issue, it just don’t works feature wise : )
There are errors in the queries so it don’t shows data in Grafana.
Sorry, I was unclear about that.
Julian
Am 02.03.20, 13:33 schrieb "Jialin Qiao" <qj...@mails.tsinghua.edu.cn>:
Hi Julian,
I could execute "mvn clean package -DskipTests" successfully including grafana.
What's the error for grafana integration you meet?
Thanks,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
> -----原始邮件-----
> 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
> 发送时间: 2020-03-02 17:55:37 (星期一)
> 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
> 抄送:
> 主题: Grafana Integration currently broken?
>
> Hi all,
>
> I just played around a bit with IoTDB-Grafana integration the last days and it seems that it works in 0.9.0 and 0.9.1 but is broken in the current master. It seems like the query there is not valid. I guess some refactoring was done but not properly tested.
> Is anyone working on that currently?
> Otherwise I would try to fix it the next days and provide an update.
>
> Julian
Re: Grafana Integration currently broken?
Posted by Jialin Qiao <qj...@mails.tsinghua.edu.cn>.
Hi Julian,
I could execute "mvn clean package -DskipTests" successfully including grafana.
What's the error for grafana integration you meet?
Thanks,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
> -----原始邮件-----
> 发件人: "Julian Feinauer" <j....@pragmaticminds.de>
> 发送时间: 2020-03-02 17:55:37 (星期一)
> 收件人: "dev@iotdb.apache.org" <de...@iotdb.apache.org>
> 抄送:
> 主题: Grafana Integration currently broken?
>
> Hi all,
>
> I just played around a bit with IoTDB-Grafana integration the last days and it seems that it works in 0.9.0 and 0.9.1 but is broken in the current master. It seems like the query there is not valid. I guess some refactoring was done but not properly tested.
> Is anyone working on that currently?
> Otherwise I would try to fix it the next days and provide an update.
>
> Julian