You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@maven.apache.org by nicolas de loof <ni...@gmail.com> on 2010/04/13 11:04:51 UTC

MRELEASE-261 - regression ?

Hi

I get some regressions with maven-release-plugin related to
http://jira.codehaus.org/browse/MRELEASE-261


Here is a testCase to demonstrate the issue. This is the same testCase as
the existing one BUT the parent project is not first one in the reactor
project list


    public void
testGetCommonBasedirOfRegularMultiModuleRootNotBeeingFirstInReactor()
        throws Exception
    {
        assertEquals( "/working/directory/flat-multi-module",
ReleaseUtil.getCommonBasedir( Arrays.asList(
            new MavenProject[]{
                createProject( "/working/directory/flat-multi-module/core"
),
                createProject( "/working/directory/flat-multi-module" ),
                createProject( "/working/directory/flat-multi-module/webapp"
)} ), '/' ) );
    }

The result from getCommonBasedir is "/working/directory/"


Should I reopen the issue or create a new one ?

Re: MRELEASE-261 - regression ?

Posted by Deng Ching <oc...@apache.org>.

Thanks!

On Tue, Apr 13, 2010 at 5:56 PM, nicolas de loof
<ni...@gmail.com>wrote:

> done http://jira.codehaus.org/browse/MRELEASE-546
>
> 2010/4/13 Deng Ching <oc...@apache.org>
>
> > Hi Nicolas,
> >
> > Please open a new one, note it as a regression and link it to
> MRELEASE-261
> > to avoid problems in the fix versions :)
> >
> > Thanks,
> > Deng
> >
> > On Tue, Apr 13, 2010 at 5:04 PM, nicolas de loof
> > <ni...@gmail.com>wrote:
> >
> > > Hi
> > >
> > > I get some regressions with maven-release-plugin related to
> > > http://jira.codehaus.org/browse/MRELEASE-261
> > >
> > >
> > > Here is a testCase to demonstrate the issue. This is the same testCase
> as
> > > the existing one BUT the parent project is not first one in the reactor
> > > project list
> > >
> > >
> > >    public void
> > > testGetCommonBasedirOfRegularMultiModuleRootNotBeeingFirstInReactor()
> > >        throws Exception
> > >    {
> > >        assertEquals( "/working/directory/flat-multi-module",
> > > ReleaseUtil.getCommonBasedir( Arrays.asList(
> > >            new MavenProject[]{
> > >                createProject(
> "/working/directory/flat-multi-module/core"
> > > ),
> > >                createProject( "/working/directory/flat-multi-module" ),
> > >                createProject(
> > "/working/directory/flat-multi-module/webapp"
> > > )} ), '/' ) );
> > >    }
> > >
> > > The result from getCommonBasedir is "/working/directory/"
> > >
> > >
> > > Should I reopen the issue or create a new one ?
> > >
> >
>

Re: MRELEASE-261 - regression ?

Posted by nicolas de loof <ni...@gmail.com>.

done http://jira.codehaus.org/browse/MRELEASE-546

2010/4/13 Deng Ching <oc...@apache.org>

> Hi Nicolas,
>
> Please open a new one, note it as a regression and link it to MRELEASE-261
> to avoid problems in the fix versions :)
>
> Thanks,
> Deng
>
> On Tue, Apr 13, 2010 at 5:04 PM, nicolas de loof
> <ni...@gmail.com>wrote:
>
> > Hi
> >
> > I get some regressions with maven-release-plugin related to
> > http://jira.codehaus.org/browse/MRELEASE-261
> >
> >
> > Here is a testCase to demonstrate the issue. This is the same testCase as
> > the existing one BUT the parent project is not first one in the reactor
> > project list
> >
> >
> >    public void
> > testGetCommonBasedirOfRegularMultiModuleRootNotBeeingFirstInReactor()
> >        throws Exception
> >    {
> >        assertEquals( "/working/directory/flat-multi-module",
> > ReleaseUtil.getCommonBasedir( Arrays.asList(
> >            new MavenProject[]{
> >                createProject( "/working/directory/flat-multi-module/core"
> > ),
> >                createProject( "/working/directory/flat-multi-module" ),
> >                createProject(
> "/working/directory/flat-multi-module/webapp"
> > )} ), '/' ) );
> >    }
> >
> > The result from getCommonBasedir is "/working/directory/"
> >
> >
> > Should I reopen the issue or create a new one ?
> >
>

Re: MRELEASE-261 - regression ?

Posted by Deng Ching <oc...@apache.org>.

Hi Nicolas,

Please open a new one, note it as a regression and link it to MRELEASE-261
to avoid problems in the fix versions :)

Thanks,
Deng

On Tue, Apr 13, 2010 at 5:04 PM, nicolas de loof
<ni...@gmail.com>wrote:

> Hi
>
> I get some regressions with maven-release-plugin related to
> http://jira.codehaus.org/browse/MRELEASE-261
>
>
> Here is a testCase to demonstrate the issue. This is the same testCase as
> the existing one BUT the parent project is not first one in the reactor
> project list
>
>
>    public void
> testGetCommonBasedirOfRegularMultiModuleRootNotBeeingFirstInReactor()
>        throws Exception
>    {
>        assertEquals( "/working/directory/flat-multi-module",
> ReleaseUtil.getCommonBasedir( Arrays.asList(
>            new MavenProject[]{
>                createProject( "/working/directory/flat-multi-module/core"
> ),
>                createProject( "/working/directory/flat-multi-module" ),
>                createProject( "/working/directory/flat-multi-module/webapp"
> )} ), '/' ) );
>    }
>
> The result from getCommonBasedir is "/working/directory/"
>
>
> Should I reopen the issue or create a new one ?
>