You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "Gilthoniel (via GitHub)" <gi...@apache.org> on 2024/08/29 08:44:24 UTC

[PR] [Issue 1274][connection] Refactor connection concurrency model [pulsar-client-go]

Gilthoniel opened a new pull request, #1275:
URL: https://github.com/apache/pulsar-client-go/pull/1275

   Fixes #1274 
   
   ### Motivation
   
   A race can happen while a consumer or a producer is registering itself to the connection to later receive closing notification.
   
   ### Modifications
   
   This pull request changes the concurrency model of the connection to properly lock the different actors between the closing procedure and the registration of handlers and listeners. After this, a caller will properly check the state of the connection and aborts if closed, and it will be certain that it will not be registered in concurrency with a closing.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is already covered by existing tests.
   
   ### Does this pull request potentially affect one of the following parts:
   
   none
   
   ### Documentation
   
   none
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Issue 1274][connection] Refactor connection concurrency model [pulsar-client-go]

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece merged PR #1275:
URL: https://github.com/apache/pulsar-client-go/pull/1275


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Issue 1274][connection] Refactor connection concurrency model [pulsar-client-go]

Posted by "frankjkelly (via GitHub)" <gi...@apache.org>.
frankjkelly commented on PR #1275:
URL: https://github.com/apache/pulsar-client-go/pull/1275#issuecomment-2346746646

   @Gilthoniel Thanks for this fix. Was this issue introduced in `0.13.1` or was does it predate that and if so do you know how far back it goes? 
   
   CC: @crossoverJie @nodece 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org