[jira] [Commented] (BOOKKEEPER-410) Hedwig client should remove message handler while closing subscription

["Sijie Guo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506255#comment-13506255 ] 

Sijie Guo commented on BOOKKEEPER-410:
--------------------------------------

I think after BOOKKEEPER-70, we had stopDelivery when closeSubscription. So I think it should already fix this issue described here. [~i0exception] Could you help double-checking about it?
                
> Hedwig client should remove message handler while closing subscription
> ----------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-410
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-410
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: hedwig-client, hedwig-server
>    Affects Versions: 4.2.0
>            Reporter: Aniruddha
>             Fix For: 4.2.0
>
>
> The hedwig java client does not remove a message handler for the topic (by calling stopDelivery) when we close a subscription channel. Because of this, when a subscription request goes through with another message handler, the subscription goes fine, but we can't start delivery. The only reason for keeping the message handler is to support restartDelivery. We should change the way restart delivery is handled by storing the existing message handler in the SubscribeReconnectCallback and forcing the subscribe handler to use it when we restart delivery. 
> This manifests as a bug in the region manager. When a topic moves from one hub to another and then returns to this hub, because the client still has a dangling MessageHandler, none of the subscriptions succeed because they can't start delivery. As an additional check, the region manager's client should not start delivery for a topic if there is an existing message handler. Any thoughts? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira