You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2023/01/12 13:26:52 UTC
[httpcomponents-client] branch master updated: Make inner classes static (#405)
This is an automated email from the ASF dual-hosted git repository.
olegk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-client.git
The following commit(s) were added to refs/heads/master by this push:
new 5ab391da9 Make inner classes static (#405)
5ab391da9 is described below
commit 5ab391da9b9b91a6e11496d9d85ac8546be1b8a3
Author: MartinWitt <wi...@gmail.com>
AuthorDate: Thu Jan 12 14:26:44 2023 +0100
Make inner classes static (#405)
---
.../hc/client5/http/impl/cache/HttpByteArrayCacheEntrySerializer.java | 2 +-
.../hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java | 2 +-
.../hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/HttpByteArrayCacheEntrySerializer.java b/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/HttpByteArrayCacheEntrySerializer.java
index ce82e73f1..9d81ae1a6 100644
--- a/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/HttpByteArrayCacheEntrySerializer.java
+++ b/httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/HttpByteArrayCacheEntrySerializer.java
@@ -385,7 +385,7 @@ public class HttpByteArrayCacheEntrySerializer implements HttpCacheEntrySerializ
* Copied from DefaultHttpResponseWriter, but wrapping a SimpleHttpResponse instead of a ClassicHttpResponse
*/
// Seems like the DefaultHttpResponseWriter should be able to do this, but it doesn't seem to be able to
- private class SimpleHttpResponseWriter extends AbstractMessageWriter<SimpleHttpResponse> {
+ private static class SimpleHttpResponseWriter extends AbstractMessageWriter<SimpleHttpResponse> {
public SimpleHttpResponseWriter() {
super(BasicLineFormatter.INSTANCE);
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java
index 7be931266..ad9582949 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java
@@ -634,7 +634,7 @@ public class PoolingHttpClientConnectionManager
private static final PrefixedIncrementingId INCREMENTING_ID = new PrefixedIncrementingId("ep-");
- class InternalConnectionEndpoint extends ConnectionEndpoint implements Identifiable {
+ static class InternalConnectionEndpoint extends ConnectionEndpoint implements Identifiable {
private final AtomicReference<PoolEntry<HttpRoute, ManagedHttpClientConnection>> poolEntryRef;
private final String id;
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
index 0fc556cb2..0212e3e49 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
@@ -670,7 +670,7 @@ public class PoolingAsyncClientConnectionManager implements AsyncClientConnectio
private static final PrefixedIncrementingId INCREMENTING_ID = new PrefixedIncrementingId("ep-");
- class InternalConnectionEndpoint extends AsyncConnectionEndpoint implements Identifiable {
+ static class InternalConnectionEndpoint extends AsyncConnectionEndpoint implements Identifiable {
private final AtomicReference<PoolEntry<HttpRoute, ManagedAsyncClientConnection>> poolEntryRef;
private final String id;