[GitHub] [incubator-doris] imay commented on a change in pull request #2310: Suport convert float to double, datetime to date by "alter table modify column type"

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2310: Suport convert float to double, datetime to date by "alter table modify column type"
URL: https://github.com/apache/incubator-doris/pull/2310#discussion_r352072077
 
 

 ##########
 File path: be/src/olap/field.h
 ##########
 @@ -187,6 +187,11 @@ class Field {
         _type_info->shallow_copy(dst, src);
     }
 
+    //convert and copy field from src to desc
+    inline OLAPStatus convert_from(char* dest, const char* src, const TypeInfo* src_type, MemPool* mem_pool) const{        
 
 Review comment:
   ```suggestion
       inline OLAPStatus convert_from(char* dest, const char* src, const TypeInfo* src_type, MemPool* mem_pool) const {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org