[jira] [Commented] (SCB-810) fix zipkin dependency

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCB-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586041#comment-16586041 ] 

ASF GitHub Bot commented on SCB-810:
------------------------------------

wujimin opened a new pull request #879: [SCB-810] fix compile error for eclipse "Photon Release (4.8.0)"
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/879
 
 
   parent class brave.http.HttpClientAdapter<Req, Resp> of ConsumerInvocationAdapter and ProviderInvocationAdapter, depend both zipkin1 and zipkin2

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> fix zipkin dependency
> ---------------------
>
>                 Key: SCB-810
>                 URL: https://issues.apache.org/jira/browse/SCB-810
>             Project: Apache ServiceComb
>          Issue Type: Bug
>          Components: Java-Chassis
>            Reporter: wujimin
>            Assignee: wujimin
>            Priority: Major
>             Fix For: java-chassis-1.1.0
>
>
> parent class brave.http.HttpClientAdapter<Req, Resp> of ConsumerInvocationAdapter and ProviderInvocationAdapter, depend both zipkin1 and zipkin2
>  
> but we set zipkin1 dependency scope to test, that cause trace handler can not compiled in eclipse "Photon Release (4.8.0)"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)