You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Narayan Periwal <na...@inmobi.com> on 2015/08/25 08:45:33 UTC
Review Request 37750: FALCON-1413: Filter By throws wrong error in
case of wrong argument being passed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37750/
-----------------------------------------------------------
Review request for Falcon.
Repository: falcon-git
Description
-------
Filter By:
Filter By throws wrong error in case of wrong argument being passed
falcon entity -list -type process -nameseq U -filterBy state
ERROR: Invalid filterBy argument : filterBy
Diffs
-----
client/src/main/java/org/apache/falcon/cli/FalconCLI.java 11f6bff
Diff: https://reviews.apache.org/r/37750/diff/
Testing
-------
Done
Thanks,
Narayan Periwal
Re: Review Request 37750: FALCON-1413: Filter By throws wrong error
in case of wrong argument being passed
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37750/#review96525
-----------------------------------------------------------
Ship it!
Ship It!
- Pallavi Rao
On Aug. 25, 2015, 12:47 p.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37750/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 12:47 p.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Filter By:
> Filter By throws wrong error in case of wrong argument being passed
> falcon entity -list -type process -nameseq U -filterBy state
> ERROR: Invalid filterBy argument : filterBy
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java 11dfe72
>
> Diff: https://reviews.apache.org/r/37750/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 37750: FALCON-1413: Filter By throws wrong error
in case of wrong argument being passed
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37750/#review97741
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Aug. 25, 2015, 12:47 p.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37750/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 12:47 p.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Filter By:
> Filter By throws wrong error in case of wrong argument being passed
> falcon entity -list -type process -nameseq U -filterBy state
> ERROR: Invalid filterBy argument : filterBy
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java 11dfe72
>
> Diff: https://reviews.apache.org/r/37750/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 37750: FALCON-1413: Filter By throws wrong error
in case of wrong argument being passed
Posted by Narayan Periwal <na...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37750/
-----------------------------------------------------------
(Updated Aug. 25, 2015, 12:47 p.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
Filter By:
Filter By throws wrong error in case of wrong argument being passed
falcon entity -list -type process -nameseq U -filterBy state
ERROR: Invalid filterBy argument : filterBy
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/cli/FalconCLI.java 11dfe72
Diff: https://reviews.apache.org/r/37750/diff/
Testing
-------
Done
Thanks,
Narayan Periwal
Re: Review Request 37750: FALCON-1413: Filter By throws wrong error
in case of wrong argument being passed
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37750/#review96310
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 602)
<https://reviews.apache.org/r/37750/#comment151629>
While you are at it, can you also change this line to explicitly say that the filterType is not valid?
client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 605)
<https://reviews.apache.org/r/37750/#comment151630>
Would be more informative if said - "Invalid filterBy argument : " + tempKeyVal[0] + " in : " + s
- Pallavi Rao
On Aug. 25, 2015, 6:45 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37750/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 6:45 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Filter By:
> Filter By throws wrong error in case of wrong argument being passed
> falcon entity -list -type process -nameseq U -filterBy state
> ERROR: Invalid filterBy argument : filterBy
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java 11f6bff
>
> Diff: https://reviews.apache.org/r/37750/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>