You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by rakeshadr <gi...@git.apache.org> on 2017/01/10 15:58:17 UTC

[GitHub] zookeeper pull request #145: ZOOKEEPER-2651: Missing src/pom.template in rel...

GitHub user rakeshadr opened a pull request:

    https://github.com/apache/zookeeper/pull/145

    ZOOKEEPER-2651: Missing src/pom.template in release

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rakeshadr/zookeeper-1 ZOOKEEPER-2651

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #145
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper issue #145: ZOOKEEPER-2651: Missing src/pom.template in release

Posted by rakeshadr <gi...@git.apache.org>.

Github user rakeshadr commented on the issue:

    https://github.com/apache/zookeeper/pull/145
  
    Thanks @eribeiro, @ctubbsii for the feedback. Sure, we will port this to 3.4, 3.5 and master as well. I think, will ensure this during release candidate verification.
    
    @hanm could you please take a look at the changes and help to merge it. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper issue #145: ZOOKEEPER-2651: Missing src/pom.template in release

Posted by eribeiro <gi...@git.apache.org>.

Github user eribeiro commented on the issue:

    https://github.com/apache/zookeeper/pull/145
  
    Oh, thanks for this patch @rakeshadr, very much appreciated. :smiley: 
    
    **to committers: we need to apply this to branch-3.4 and branch-3.5 too, besides master, please** :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #145: ZOOKEEPER-2651: Missing src/pom.template in rel...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zookeeper/pull/145


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper issue #145: ZOOKEEPER-2651: Missing src/pom.template in release

Posted by hanm <gi...@git.apache.org>.

Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/145
  
    lgtm, merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper issue #145: ZOOKEEPER-2651: Missing src/pom.template in release

Posted by ctubbsii <gi...@git.apache.org>.

Github user ctubbsii commented on the issue:

    https://github.com/apache/zookeeper/pull/145
  
    Happy to see this fixed. Would be great to incorporate something into ZK release testing/voting procedures to ensure project can actually be built from the official release artifact so this doesn't happen in future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---