[GitHub] [spark] cloud-fan commented on a diff in pull request #37320: [SPARK-39819][SQL] DS V2 aggregate push down can work with Top N or Paging (Sort with expressions)

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #37320:
URL: https://github.com/apache/spark/pull/37320#discussion_r940865099


##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Cast.java:
##########
@@ -42,4 +42,9 @@ public Cast(Expression expression, DataType dataType) {
 
   @Override
   public Expression[] children() { return new Expression[]{ expression() }; }
+
+  @Override
+  public String toString() {

Review Comment:
   is this the only missing one? maybe we should add a default implementation in the base class `Expression` using `ToStringSQLBuilder`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org