You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/04 16:00:29 UTC
[GitHub] [lucene-solr] msokolov opened a new pull request #2303: LUCENE-9715: fix int overflow in Lucene90VectorReader
msokolov opened a new pull request #2303:
URL: https://github.com/apache/lucene-solr/pull/2303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mikemccand commented on pull request #2303: LUCENE-9715: fix int overflow in Lucene90VectorReader
Posted by GitBox <gi...@apache.org>.
mikemccand commented on pull request #2303:
URL: https://github.com/apache/lucene-solr/pull/2303#issuecomment-773533648
> I like Lucene's randomized tests too! But they didn't find this one. Since it requires a 2GB index to detect, it only turned up in the context of Anton's version of "nightly" benchmarks - I wonder if they are crashing for you?
Ahh, good point. It is also exciting when our benchmarks catch bugs that our unit tests miss!
Oddly/scarily, the nightly benchmarks are NOT failing for me -- I just checked last night's. I wonder why not? Hmm, could it be because we accidentally stopped retrieving vectors in search tasks?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] msokolov commented on pull request #2303: LUCENE-9715: fix int overflow in Lucene90VectorReader
Posted by GitBox <gi...@apache.org>.
msokolov commented on pull request #2303:
URL: https://github.com/apache/lucene-solr/pull/2303#issuecomment-773529165
I like Lucene's randomized tests too! But they didn't find this one. Since it requires a 2GB index to detect, it only turned up in the context of Anton's version of "nightly" benchmarks - I wonder if they are crashing for you?
Separately I think it would be cool if we did have a way of surfacing such bugs with randomized tests.
Anyway I'll push this now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] msokolov merged pull request #2303: LUCENE-9715: fix int overflow in Lucene90VectorReader
Posted by GitBox <gi...@apache.org>.
msokolov merged pull request #2303:
URL: https://github.com/apache/lucene-solr/pull/2303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] msokolov merged pull request #2303: LUCENE-9715: fix int overflow in Lucene90VectorReader
Posted by GitBox <gi...@apache.org>.
msokolov merged pull request #2303:
URL: https://github.com/apache/lucene-solr/pull/2303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] msokolov commented on pull request #2303: LUCENE-9715: fix int overflow in Lucene90VectorReader
Posted by GitBox <gi...@apache.org>.
msokolov commented on pull request #2303:
URL: https://github.com/apache/lucene-solr/pull/2303#issuecomment-773529165
I like Lucene's randomized tests too! But they didn't find this one. Since it requires a 2GB index to detect, it only turned up in the context of Anton's version of "nightly" benchmarks - I wonder if they are crashing for you?
Separately I think it would be cool if we did have a way of surfacing such bugs with randomized tests.
Anyway I'll push this now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mikemccand commented on pull request #2303: LUCENE-9715: fix int overflow in Lucene90VectorReader
Posted by GitBox <gi...@apache.org>.
mikemccand commented on pull request #2303:
URL: https://github.com/apache/lucene-solr/pull/2303#issuecomment-773533648
> I like Lucene's randomized tests too! But they didn't find this one. Since it requires a 2GB index to detect, it only turned up in the context of Anton's version of "nightly" benchmarks - I wonder if they are crashing for you?
Ahh, good point. It is also exciting when our benchmarks catch bugs that our unit tests miss!
Oddly/scarily, the nightly benchmarks are NOT failing for me -- I just checked last night's. I wonder why not? Hmm, could it be because we accidentally stopped retrieving vectors in search tasks?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org