You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/12 05:57:37 UTC

[GitHub] [doris] HappenLee commented on a diff in pull request #10775: [Bug][Memtable] fix core dump on int128 because not aligned by 16 byte

HappenLee commented on code in PR #10775:
URL: https://github.com/apache/doris/pull/10775#discussion_r918575131


##########
be/src/runtime/mem_pool.h:
##########
@@ -104,9 +104,17 @@ class MemPool {
     /// of the current chunk. Creates a new chunk if there aren't any chunks
     /// with enough capacity.
     uint8_t* allocate(int64_t size, Status* rst = nullptr) {
+        // TODO: rethink if DEFAULT_ALIGNMENT should be 82, malloc is aligned by 16.

Review Comment:
   not 82?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org