You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/03/21 14:29:55 UTC
[kudu-CR] [spark] Fix scala formatting
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12821
Change subject: [spark] Fix scala formatting
......................................................................
[spark] Fix scala formatting
The automatic scala formatting wasn’t run on a patch and
subsequent builds are being formatted.
This patch fixes the formatting.
Change-Id: Ia96003e3cd70a65532b90adbc98edbab93f116bf
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/12821/1
--
To view, visit http://gerrit.cloudera.org:8080/12821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia96003e3cd70a65532b90adbc98edbab93f116bf
Gerrit-Change-Number: 12821
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [spark] Fix scala formatting
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12821 )
Change subject: [spark] Fix scala formatting
......................................................................
Patch Set 1: Code-Review+2
It's actually really frustrating that the scala formatter _makes source files changes_ during the build. Even when it has no changes to make, my editor still detects that files were rewritten underneath it and asks me what to do, which needlessly interrupts my work.
Can we change it to generate warnings instead, and, if there are recommended changes, show the user the gradle invocation that will actually rewrites files?
--
To view, visit http://gerrit.cloudera.org:8080/12821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia96003e3cd70a65532b90adbc98edbab93f116bf
Gerrit-Change-Number: 12821
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 Mar 2019 18:37:57 +0000
Gerrit-HasComments: No
[kudu-CR] [spark] Fix scala formatting
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12821 )
Change subject: [spark] Fix scala formatting
......................................................................
[spark] Fix scala formatting
The automatic scala formatting wasn’t run on a patch and
subsequent builds are being formatted.
This patch fixes the formatting.
Change-Id: Ia96003e3cd70a65532b90adbc98edbab93f116bf
Reviewed-on: http://gerrit.cloudera.org:8080/12821
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia96003e3cd70a65532b90adbc98edbab93f116bf
Gerrit-Change-Number: 12821
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)