You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2016/12/15 23:42:08 UTC

[kudu-CR] KUDU-1805: (Follow up) Add missing 'using' declaration to RPC protoc-gen

Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5530

Change subject: KUDU-1805: (Follow up) Add missing 'using' declaration to RPC protoc-gen
......................................................................

KUDU-1805: (Follow up) Add missing 'using' declaration to RPC protoc-gen

Change-Id: I2ae7ebe287884450339f7fb9972ebcff598bb9d7
---
M src/kudu/rpc/protoc-gen-krpc.cc
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/5530/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ae7ebe287884450339f7fb9972ebcff598bb9d7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>

[kudu-CR] KUDU-1805: (Follow up) Add missing 'using' declaration to RPC protoc-gen

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: KUDU-1805: (Follow up) Add missing 'using' declaration to RPC protoc-gen
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ae7ebe287884450339f7fb9972ebcff598bb9d7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-1805: (Follow up) Add missing 'using' declaration to RPC protoc-gen

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.

Change subject: KUDU-1805: (Follow up) Add missing 'using' declaration to RPC protoc-gen
......................................................................


KUDU-1805: (Follow up) Add missing 'using' declaration to RPC protoc-gen

Change-Id: I2ae7ebe287884450339f7fb9972ebcff598bb9d7
Reviewed-on: http://gerrit.cloudera.org:8080/5530
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/rpc/protoc-gen-krpc.cc
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2ae7ebe287884450339f7fb9972ebcff598bb9d7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins